Skip to content

support batch checking of references and unmapping for large folios

Baolin Wang linux-arm-kernel linux-mm lkml 6 versions – Applied

Status from this message: [merged mm-stable] mm-rmap-support-batched-unmapping-for-file-large-folios.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 34 repliesApplied 5/5
  2. v55 patches 41 repliesSuperseded
  3. v45 patches 9 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches3 repliesSuperseded
v23 patches31 repliesSuperseded
v12 patches4 repliesSuperseded

Changes in v6 from the cover letter

- Collect reviewed tags from Ryan, Harry and David. Thanks.
- Fix some coding style issues (per David).
- Skip batched unmapping for uffd case, reported by Dev. Thanks.

Patches in v6 All 5 applied

#Subject and filesSizeRepliesApplied
1/5mm: rmap: support batched checks of the references for large foliosinclude/linux/mmu_notifier.h include/linux/pgtable.h mm/rmap.c+65 -726 repliesApplied
2/5arm64: mm: factor out the address and ptep alignment into a new helperarch/arm64/mm/contpte.c+21 -80 repliesApplied
3/5arm64: mm: support batch clearing of the young flag for large foliosarch/arm64/include/asm/pgtable.h arch/arm64/mm/contpte.c+25 -200 repliesApplied
4/5arm64: mm: implement the architecture-specific clear_flush_young_ptes()arch/arm64/include/asm/pgtable.h+11 -05 repliesApplied
5/5mm: rmap: support batched unmapping for file large foliosmm/rmap.c+7 -31 replyApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchDavid Hildenbrand (Arm)Ryan RobertsHarry YooBarry Song
1/5A-b R-b R-b R-b
2/5R-b R-b
3/5R-b R-b
4/5R-b R-b R-b
5/5A-b R-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/5] support batch checking of references and unmapping for large folios

Currently, folio_referenced_one() always checks the young flag for each PTE sequentially, which is inefficient for large folios. This inefficiency is especially noticeable when reclaiming clean file-backed large folios, where folio_referenced() is observed as a significant performance hotspot.

Moreover, on Arm architecture, which supports contiguous PTEs, there is already an optimization to clear the young flags for PTEs within a contiguous range. However, this is not sufficient. We can extend this to perform batched operations for the entire large folio (which might exceed the contiguous range: CONT_PTE_SIZE).

Similar to folio_referenced_one(), we can also apply batched unmapping for large file folios to optimize the performance of file folio reclamation. By supporting batched checking of the young flags, flushing TLB entries, and unmapping, I can observed a significant performance improvements in my performance tests for file folios reclamation. Please check the performance data in the commit message of each patch.

Run stress-ng and mm selftests, no issues were found.

Patch 1: Add a new generic batched PTE helper that supports batched checks of the references for large folios.
Patch 2 - 3: Preparation patches.
patch 4: Implement the Arm64 arch-specific clear_flush_young_ptes(). Patch 5: Support batched unmapping for file large folios.

Changes from v5:
- Collect reviewed tags from Ryan, Harry and David. Thanks.
- Fix some coding style issues (per David).
- Skip batched unmapping for uffd case, reported by Dev. Thanks.

Changes from v4:
- Fix passing the incorrect 'CONT_PTES' for non-batched APIs.
- Rename ptep_clear_flush_young_notify() to clear_flush_young_ptes_notify() (per Ryan).
- Fix some coding style issues (per Ryan).
- Add reviewed tag from Ryan. Thanks.

Changes from v3:
- Fix using an incorrect parameter in ptep_clear_flush_young_notify() (per Liam).

Changes from v2:
- Rearrange the patch set (per Ryan).
- Add pte_cont() check in clear_flush_young_ptes() (per Ryan).
- Add a helper to do contpte block alignment (per Ryan).
- Fix some coding style issues (per Lorenzo and Ryan).
- Add more comments and update the commit message (per Lorenzo and Ryan).
- Add acked tag from Barry. Thanks.

Changes from v1:
- Add a new patch to support batched unmapping for file large folios.
- Update the cover letter

Baolin Wang (5):
mm: rmap: support batched checks of the references for large folios
arm64: mm: factor out the address and ptep alignment into a new helper
arm64: mm: support batch clearing of the young flag for large folios
arm64: mm: implement the architecture-specific
clear_flush_young_ptes()
mm: rmap: support batched unmapping for file large folios

 arch/arm64/include/asm/pgtable.h | 23 ++++++++----
 arch/arm64/mm/contpte.c          | 62 ++++++++++++++++++++------------
 include/linux/mmu_notifier.h     |  9 ++---
 include/linux/pgtable.h          | 35 ++++++++++++++++++
 mm/rmap.c                        | 38 ++++++++++++++++----
 5 files changed, 129 insertions(+), 38 deletions(-)
Signature · 1 line
2.47.3