smb: smbdirect/client/server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 17 repliesIn review
- v24 patches 0 repliesSuperseded
- v14 patches 4 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | smb: smbdirect: introduce SMBDIRECT_DEBUG_ERR_PTR() helperfs/ | +13 | 0 replies | |
| 2/4 | smb: smbdirect: introduce SMBDIRECT_CHECK_STATUS_{WARN,DISCONNECT}()fs/ | +38 | 0 replies | |
| 3/4 | smb: server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks in recv_done() and smb_direct_cm_handler()fs/ | +32 | 0 replies | |
| 4/4 | smb: client: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks in recv_done() and smbd_conn_upcall()fs/ | +15 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/4] smb: smbdirect/client/server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks
Hi,
here are some small cleanups for a problem Nanjae reported, where two WARN_ON_ONCE(sc->status != ...) checks where triggered by a Windows 11 client.
The patches should relax the checks if an error happened before, they are intended for 6.18 final, as far as I can see the problem was introduced during the 6.18 cycle only.
Given that v1 of this patchset produced a very useful WARN_ONCE() message, I'd really propose to keep this for 6.18, also for the client where the actual problem may not exists, but if they exist, it will be useful to have the more useful messages in 6.16 final.
Thanks!
metze
v3: move __SMBDIRECT_SOCKET_DISCONNECT() defines before including
smbdirect headers in order to avoid problems with the follow up changes for 6.19
v2: adjust for the case where the recv completion arrives before
RDMA_CM_EVENT_ESTABLISHED and improve commit messages
Stefan Metzmacher (4):
smb: smbdirect: introduce SMBDIRECT_DEBUG_ERR_PTR() helper
smb: smbdirect: introduce SMBDIRECT_CHECK_STATUS_{WARN,DISCONNECT}()
smb: server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks in
recv_done() and smb_direct_cm_handler()
smb: client: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks in
recv_done() and smbd_conn_upcall()
fs/smb/client/smbdirect.c | 28 ++++++------ fs/smb/common/smbdirect/smbdirect_socket.h | 51 ++++++++++++++++++++++ fs/smb/server/transport_rdma.c | 40 +++++++++++++---- 3 files changed, 98 insertions(+), 21 deletions(-)
Signature · 1 line
2.43.0