Skip to content

btrfs-progs: add block-group-tree to the default mkfs/convert features

Qu Wenruo linux-btrfs 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 1 replySuperseded

Changes in v2 from the cover letter

- Automatically remove bgt feature when dependent feature is missing Instead of erroring out. This will allow us to run the existing no-holes/v1 free space cache test cases without any modification.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs-progs: disable block-group-tree feature if dependency is missingDocumentation/mkfs.btrfs.rst convert/main.c mkfs/main.c+14 -50 replies
2/3btrfs-progs: misc-tests: check if free space tree is enabled after mounttests/misc-tests/057-btrfstune-free-space-tree/test.sh+8 -00 replies
3/3btrfs-progs: add block-group-tree to the default mkfs featuresDocumentation/mkfs.btrfs.rst common/fsfeatures.c common/fsfeatures.h+4 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] btrfs-progs: add block-group-tree to the default mkfs/convert features

[CHANGELOG]
v2:
- Automatically remove bgt feature when dependent feature is missing Instead of erroring out. This will allow us to run the existing no-holes/v1 free space cache test cases without any modification.

I was planning to do this during v6.12 but forgot it and now the next LTS kernel release is not that far away, it's finally time to make the switch.

The first patch is to change mkfs/btrfs-convert from rejecting "bgt,^no-holes" to disabling bgt when no-holes/fst feature is not selected.
This allows the existing "mkfs.btrfs ^no-holes" to be executed without extra modification.

The second patch is a large page-size specific fix, where on 64K page size systems misc/057 will fail due to subpage mounts always enable v2 free space cache, resulting later conversion failure to fst (as it's already fst).

The final patch is the one enabling new default block-group-tree feature for mkfs and convert.

Qu Wenruo (3):
btrfs-progs: disable block-group-tree feature if dependency is missing
btrfs-progs: misc-tests: check if free space tree is enabled after
mount
btrfs-progs: add block-group-tree to the default mkfs features

 Documentation/mkfs.btrfs.rst                           |  7 ++++++-
 common/fsfeatures.c                                    |  2 +-
 common/fsfeatures.h                                    |  3 ++-
 convert/main.c                                         |  4 ++--
 mkfs/main.c                                            | 10 +++++++---
 tests/misc-tests/057-btrfstune-free-space-tree/test.sh |  8 ++++++++
 6 files changed, 26 insertions(+), 8 deletions(-)

--
2.52.0