Skip to content

Fix up NFS client mount option regressions

Trond Myklebust linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Revert "nfs: ignore SB_RDONLY when remounting nfs"fs/nfs/super.c+0 -100 replies
2/6Revert "nfs: clear SB_RDONLY before getting superblock"fs/nfs/super.c+0 -90 replies
3/6Revert "nfs: ignore SB_RDONLY when mounting nfs"fs/nfs/internal.h+1 -10 replies
4/6NFS: Automounted filesystem should inherit ro,noexec,nodev,sync flagsfs/nfs/namespace.c fs/nfs/super.c+6 -40 replies
5/6NFS: Fix inheritance of the block sizes when automountingfs/nfs/client.c fs/nfs/internal.h fs/nfs/namespace.c +3 more+43 -170 replies
6/6NFS: Fix up the automount fs_context to use the correct credfs/nfs/namespace.c+5 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] Fix up NFS client mount option regressions

From: Trond Myklebust <[email protected]>

The recent changes to suppress the 'ro' and 'rw' mount options when mounting the same NFS filesystem with different settings are causing confusion with users, and are an unnecessary restriction. They represent a functionality regression.

The following patch set reverts the regressions, before applying a different set of fixes to address the original problem, which was one of the NFSv4 mount automounter code failing to propagate the correct mount options.

Trond Myklebust (6):
Revert "nfs: ignore SB_RDONLY when remounting nfs"
Revert "nfs: clear SB_RDONLY before getting superblock" Revert "nfs: ignore SB_RDONLY when mounting nfs"
NFS: Automounted filesystem should inherit ro,noexec,nodev,sync flags
NFS: Fix inheritance of the block sizes when automounting
NFS: Fix up the automount fs_context to use the correct cred

 fs/nfs/client.c           | 21 +++++++++++++++++----
 fs/nfs/internal.h         |  3 +--
 fs/nfs/namespace.c        | 16 +++++++++++++++-
 fs/nfs/nfs4client.c       | 18 ++++++++++++++----
 fs/nfs/super.c            | 33 +++------------------------------
 include/linux/nfs_fs_sb.h |  5 +++++
 6 files changed, 55 insertions(+), 41 deletions(-)
Signature · 1 line
2.52.0