Skip to content

fsi: Convert to bus probe mechanism

Uwe Kleine-König linux-i2c linux-spi lkml openbmc 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 15 repliesIn review
  2. v112 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13fsi: Make use of module_fsi_driver()drivers/fsi/fsi-sbefifo.c drivers/fsi/fsi-scom.c+2 -241 reply
2/13fsi: Assign driver's bus in fsi_driver_register()drivers/fsi/fsi-core.c drivers/fsi/fsi-master-hub.c drivers/fsi/fsi-sbefifo.c +2 more+2 -41 reply
3/13fsi: Provide thin wrappers around dev_[gs]et_data() for fsi devicesinclude/linux/fsi.h+10 -01 reply
4/13i2c: fsi: Drop assigning fsi busdrivers/i2c/busses/i2c-fsi.c+0 -11 reply
5/13spi: fsi: Drop assigning fsi busdrivers/spi/spi-fsi.c+0 -11 reply
6/13fsi: Make fsi_bus_type a private variable to the coredrivers/fsi/fsi-core.c include/linux/fsi.h+33 -351 reply
7/13fsi: Create bus specific probe and remove functionsdrivers/fsi/fsi-core.c include/linux/fsi.h+52 -01 reply
8/13fsi: i2cr-scom: Convert to fsi bus probe mechanismdrivers/fsi/i2cr-scom.c+6 -81 reply
9/13fsi: master: Convert to fsi bus probe mechanismdrivers/fsi/fsi-master-hub.c+7 -91 reply
10/13fsi: sbefifo: Convert to fsi bus probe mechanismdrivers/fsi/fsi-sbefifo.c+8 -91 reply
11/13fsi: scom: Convert to fsi bus probe mechanismdrivers/fsi/fsi-scom.c+7 -91 reply
12/13i2c: fsi: Convert to fsi bus probe mechanismdrivers/i2c/busses/i2c-fsi.c+7 -81 reply
13/13spi: fsi: Convert to fsi bus probe mechanismdrivers/spi/spi-fsi.c+3 -31 reply

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchAndi ShytiMark BrownEddie James
1/13A-b
2/13A-b
3/13A-b
4/13R-b A-b
5/13A-b A-b
6/13A-b
7/13A-b
8/13A-b
9/13A-b
10/13A-b
11/13A-b
12/13R-b A-b
13/13A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/13] fsi: Convert to bus probe mechanism

Hello,

this is the 2nd installment of the series converting the fsi bus to use bus methods for .probe and .remove. The changes since the first iteration---that can be found at
https://lore.kernel.org/lkml/[email protected]/
--- are:

- (trivially) rebase to v6.18
- add tags by Andi (for the i2c parts) and Mark Brown (for the spi parts)
- Add a patch converting drivers/fsi/i2cr-scom.c (#8)

In the earlier thread I thought I made a mistake for (implicit) v1, but I confused fsi with fsl and the problem doesn't apply here as it doesn't touch the shutdown callback.

This series is not urgent, but it would be great to get this into v6.19-rc1. With Mark's Acks and Andi's tags (though they are not an Ack) this should be fine to be picked up in one go by Eddie.

As before there are two commit refs that should refer to the commit for patch #2 ("fsi: Assign driver's bus in fsi_driver_register()"). As I cannot know the commit hash yet, I wrote "FIXME" and these need updating when the series is picked up.

Thanks
Uwe

Uwe Kleine-König (13):
fsi: Make use of module_fsi_driver()
fsi: Assign driver's bus in fsi_driver_register()
fsi: Provide thin wrappers around dev_[gs]et_data() for fsi devices
i2c: fsi: Drop assigning fsi bus
spi: fsi: Drop assigning fsi bus
fsi: Make fsi_bus_type a private variable to the core
fsi: Create bus specific probe and remove functions
fsi: i2cr-scom: Convert to fsi bus probe mechanism
fsi: master: Convert to fsi bus probe mechanism
fsi: sbefifo: Convert to fsi bus probe mechanism
fsi: scom: Convert to fsi bus probe mechanism
i2c: fsi: Convert to fsi bus probe mechanism
spi: fsi: Convert to fsi bus probe mechanism

 drivers/fsi/fsi-core.c       | 107 ++++++++++++++++++++++++++---------
 drivers/fsi/fsi-master-hub.c |  17 +++---
 drivers/fsi/fsi-sbefifo.c    |  31 +++-------
 drivers/fsi/fsi-scom.c       |  30 +++-------
 drivers/fsi/i2cr-scom.c      |  15 ++---
 drivers/i2c/busses/i2c-fsi.c |  16 +++---
 drivers/spi/spi-fsi.c        |   7 +--
 include/linux/fsi.h          |  13 ++++-
 8 files changed, 131 insertions(+), 105 deletions(-)

base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449

Signature · 1 line
2.47.3