Skip to content

RFC net: gro: avoid touching transport header

Paolo Abeni netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: gro: avoid relaying on skb->transport_header at receive timeinclude/net/gro.h include/net/tcp.h net/ipv4/tcp_offload.c +2 more+39 -114 replies
2/2net: gro: set the transport header laternet/ipv4/af_inet.c net/ipv4/tcp_offload.c net/ipv4/udp_offload.c +1 more+7 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/2] net: gro: avoid touching transport header

This series is basically a pre-req for GRO support for double UDP encapsulation:

https://lore.kernel.org/netdev/[email protected]/

that otherwise would requiring explicitly disabling gro on the outer geneve device.

I *think* it should also help plain TCP GRO performances, even if don't have a very high speed, full zero-copy, big TCP testbed handy to actually prove it - see patch 1 for the gory details.

Paolo Abeni (2):
net: gro: avoid relaying on skb->transport_header at receive time
net: gro: set the transport header later

 include/net/gro.h        | 26 ++++++++++++++++++++++++++
 include/net/tcp.h        |  3 ++-
 net/ipv4/af_inet.c       |  2 +-
 net/ipv4/tcp_offload.c   | 16 +++++++++-------
 net/ipv4/udp_offload.c   |  8 ++++++--
 net/ipv6/ip6_offload.c   |  3 +--
 net/ipv6/tcpv6_offload.c |  2 +-
 7 files changed, 46 insertions(+), 14 deletions(-)
Signature · 1 line
2.52.0

Read the cover letter in its thread