Skip to content

mcp: support multiple MCP and implement local GMCS

Pauli Virtanen linux-bluetooth 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6shared/mcp: support multiple MCP, and add non-stub MCS serverlib/bluetooth/uuid.h src/shared/mcp.c src/shared/mcp.h +1 more+2093 -13941 reply
2/6test-mcp: add tests for MCP / MCS.gitignore Makefile.am unit/test-mcp.c+1814 -00 replies
3/6mcp: adapt to new MCP API to support multiple remote MCS servicesprofiles/audio/mcp.c+408 -2401 reply
4/6avctp: move uinput utilities to uinput-util.cMakefile.plugins profiles/audio/avctp.c profiles/audio/uinput-util.c +1 more+178 -1110 replies
5/6mcp: add local GMCS service that emits uinput media keysprofiles/audio/mcp.c+162 -00 replies
6/6shared/gatt-client: fix notify_data leak in notify_data_write_cccsrc/shared/gatt-client.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH BlueZ 0/6] mcp: support multiple MCP and implement local GMCS

For Media Control Client, add support for multiple GMCS / MCS services on the server. Revise the API accordingly.

For Media Control Server, make it a non-stub implementation (OTS still missing), and add an API the profile can use.

Add tests.

This changes the design of the previous MCP code, so it's mostly a rewrite.

The shared/mcp: commit doesn't fix the API in profiles/audio, that's done in the later mcp: commit, as it's a rewrite of the API.

TODO (for later): OTP/OTS parts -- requires design for OTP/OTS implementation first

TODO (for later): MPRIS integration to GMCS server -- this needs some redesign in media.c as it's hardcoded to AVRCP there.

Pauli Virtanen (6):
shared/mcp: support multiple MCP, and add non-stub MCS server
test-mcp: add tests for MCP / MCS
mcp: adapt to new MCP API to support multiple remote MCS services
avctp: move uinput utilities to uinput-util.c
mcp: add local GMCS service that emits uinput media keys shared/gatt-client: fix notify_data leak in notify_data_write_ccc

 .gitignore                   |    1 +
 Makefile.am                  |    6 +
 Makefile.plugins             |    3 +-
 lib/bluetooth/uuid.h         |   27 +-
 profiles/audio/avctp.c       |  119 +-
 profiles/audio/mcp.c         |  802 ++++++---
 profiles/audio/uinput-util.c |  144 ++
 profiles/audio/uinput-util.h |   23 +
 src/shared/gatt-client.c     |    3 +
 src/shared/mcp.c             | 3223 ++++++++++++++++++++--------------
 src/shared/mcp.h             |  186 +-
 src/shared/mcs.h             |   51 +-
 unit/test-mcp.c              | 1807 +++++++++++++++++++
 13 files changed, 4654 insertions(+), 1741 deletions(-)
 create mode 100644 profiles/audio/uinput-util.c
 create mode 100644 profiles/audio/uinput-util.h
 create mode 100644 unit/test-mcp.c
Signature · 1 line
2.51.1