mcp: support multiple MCP and implement local GMCS
Status from this message: This series was applied to bluetooth/bluez.git (master)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest9 patches 1 replyApplied
- v69 patches 1 replySuperseded
- v57 patches 6 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 7 patches | 1 reply | Superseded | |
| v3 | 7 patches | 2 replies | Superseded | |
| v1 | 7 patches | 2 replies | Superseded |
Changes in v7 from the cover letter
- fix -Werror=unused-result
Patches in v7 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | shared/mcp, mcp: support multiple MCP, and add non-stub MCS serverlib/ profiles/ src/ +2 more | +2362 | 1 reply | |
| 2/9 | test-mcp: add tests for MCP / MCS.gitignore Makefile.am unit/ | +1814 | 0 replies | |
| 3/9 | mcp: add support for Repeat & Shuffle for remote playerprofiles/ | +118 | 0 replies | |
| 4/9 | shared/uinput: add uinput utility functionsMakefile.am src/ src/ | +238 | 0 replies | |
| 5/9 | avctp: use uinput utilities from src/sharedprofiles/ | +40 | 0 replies | |
| 6/9 | mcp: add local GMCS service that emits uinput media keysprofiles/ | +180 | 0 replies | |
| 7/9 | shared/mcp: on track changed, re-read values if notify not availablesrc/ | +14 | 0 replies | |
| 8/9 | test-mcp: check attributes are reread on track change if no notifyunit/ | +52 | 0 replies | |
| 9/9 | shared/mcp: complete CCID read before considering other attributessrc/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.
Cover letter [PATCH BlueZ v7 0/9] mcp: support multiple MCP and implement local GMCS
v7:
- fix -Werror=unused-result
v6:
- use only rewritten bt_uinput to be able to change license
- make all patches buildable, combining commits
- in that, split out mcp: add support for Repeat & Shuffle
- fixup: re-read of values on track change if remote doesn't notify
- fixup: make sure other values are read only after CCID
v5:
- fix -D_FORTIFY_SOURCE false positive vs. strncpy in the old avctp code in testbot environment
v4:
- move uinput-util.h to src/shared + adapt accordingly
- improve debug logs in profile
v3:
- add missing #include to fix build in the test environment
v2:
- fix compilation issues
- remove unnecessary code in get_media_cp_op_supported
***
For Media Control Client, add support for multiple GMCS / MCS services on the server. Revise the API accordingly.
For Media Control Server, make it a non-stub implementation (OTS still missing), and add an API the profile can use.
Add tests.
This changes the design of the previous MCP code, so it's mostly a rewrite.
The shared/mcp: commit doesn't fix the API in profiles/audio, that's done in the later mcp: commit, as it's a rewrite of the API.
TODO (for later): OTP/OTS parts -- requires design for OTP/OTS implementation first
TODO (for later): MPRIS integration to GMCS server -- this needs some redesign in media.c as it's hardcoded to AVRCP there.
Tested devices (MCS):
- Creative Zen Hybrid Pro (doesn't even connect without GMCS)
- Samsung Galaxy Buds Pro2
- Creative Aurvana Ace 2
Tested devices (MCP):
- Samsung Galaxy A56
Pauli Virtanen (9):
shared/mcp, mcp: support multiple MCP, and add non-stub MCS server
test-mcp: add tests for MCP / MCS
mcp: add support for Repeat & Shuffle for remote player shared/uinput: add uinput utility functions
avctp: use uinput utilities from src/shared
mcp: add local GMCS service that emits uinput media keys shared/mcp: on track changed, re-read values if notify not available
test-mcp: check attributes are reread on track change if no notify shared/mcp: complete CCID read before considering other attributes
.gitignore | 1 + Makefile.am | 9 +- lib/bluetooth/uuid.h | 27 +- profiles/audio/avctp.c | 166 +-- profiles/audio/mcp.c | 808 +++++++--- src/shared/mcp.c | 3216 +++++++++++++++++++++++----------------- src/shared/mcp.h | 186 ++- src/shared/mcs.h | 51 +- src/shared/uinput.c | 204 +++ src/shared/uinput.h | 32 + unit/test-mcp.c | 1859 +++++++++++++++++++++++ 11 files changed, 4802 insertions(+), 1757 deletions(-) create mode 100644 src/shared/uinput.c create mode 100644 src/shared/uinput.h create mode 100644 unit/test-mcp.c
Signature · 1 line
2.51.1