fix DMA aligment issues around virtio
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest15 patches 26 repliesIn review
- v1 RFC13 patches 16 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | dma-mapping: add __dma_from_device_group_begin()/end()include/ | +13 | 2 replies | |
| 2/15 | docs: dma-api: document __dma_from_device_group_begin()/end()Documentation/ | +52 | 2 replies | |
| 3/15 | dma-mapping: add DMA_ATTR_CPU_CACHE_CLEANinclude/ kernel/ | +9 | 2 replies | |
| 4/15 | docs: dma-api: document DMA_ATTR_CPU_CACHE_CLEANDocumentation/ | +9 | 2 replies | |
| 5/15 | dma-debug: track cache clean flag in entrieskernel/ | +22 | 3 replies | |
| 6/15 | virtio: add virtqueue_add_inbuf_cache_clean APIdrivers/ include/ | +65 | 0 replies | |
| 7/15 | vsock/virtio: fix DMA alignment for event_listnet/ | +3 | 3 replies | |
| 8/15 | vsock/virtio: use virtqueue_add_inbuf_cache_clean for eventsnet/ | +1 | 1 reply | |
| 9/15 | virtio_input: fix DMA alignment for evtsdrivers/ | +3 | 0 replies | |
| 10/15 | virtio_scsi: fix DMA cacheline issues for eventsdrivers/ | +12 | 4 replies | |
| 11/15 | virtio-rng: fix DMA alignment for data bufferdrivers/ | +3 | 0 replies | |
| 12/15 | virtio_input: use virtqueue_add_inbuf_cache_clean for eventsdrivers/ | +1 | 0 replies | |
| 13/15 | vsock/virtio: reorder fields to reduce paddingnet/ | +5 | 5 replies | |
| 14/15 | gpio: virtio: fix DMA alignmentdrivers/ | +10 | 1 reply | |
| 15/15 | gpio: virtio: reorder fields to reduce struct paddingdrivers/ | +2 | 3 replies |
Reviews trailers per patch
10 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Viresh Kumar | Petr Tesarik | Bartosz Golaszewski | Marek Szyprowski | Stefan Hajnoczi | Stefano Garzarella |
|---|---|---|---|---|---|---|
| 1/15 | R-b | A-b | ||||
| 2/15 | R-b | A-b | ||||
| 3/15 | R-b | A-b | ||||
| 4/15 | R-b | A-b | ||||
| 5/15 | R-b | |||||
| 6/15 | ||||||
| 7/15 | A-b | |||||
| 8/15 | A-b | |||||
| 9/15 | ||||||
| 10/15 | R-b | |||||
| 11/15 | ||||||
| 12/15 | ||||||
| 13/15 | ||||||
| 14/15 | A-b | A-b | ||||
| 15/15 | A-b | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.
Cover letter [PATCH v2 00/15] fix DMA aligment issues around virtio
Cong Wang reported dma debug warnings with virtio-vsock and proposed a patch, see:
https://lore.kernel.org/all/[email protected]/
however, the issue is more widespread.
This is an attempt to fix it systematically.
Note: i2c and gio might also be affected, I am still looking into it. Help from maintainers welcome.
Lightly tested. Cursor/claude used liberally, mostly for refactoring/API updates/English.
DMA maintainers, could you please confirm the DMA core changes are ok with you?
Thanks!
Michael S. Tsirkin (15):
dma-mapping: add __dma_from_device_group_begin()/end()
docs: dma-api: document __dma_from_device_group_begin()/end()
dma-mapping: add DMA_ATTR_CPU_CACHE_CLEAN
docs: dma-api: document DMA_ATTR_CPU_CACHE_CLEAN
dma-debug: track cache clean flag in entries
virtio: add virtqueue_add_inbuf_cache_clean API vsock/virtio: fix DMA alignment for event_list vsock/virtio: use virtqueue_add_inbuf_cache_clean for events
virtio_input: fix DMA alignment for evts
virtio_scsi: fix DMA cacheline issues for events
virtio-rng: fix DMA alignment for data buffer
virtio_input: use virtqueue_add_inbuf_cache_clean for events vsock/virtio: reorder fields to reduce padding
gpio: virtio: fix DMA alignment
gpio: virtio: reorder fields to reduce struct padding
Documentation/core-api/dma-api-howto.rst | 52 ++++++++++++++ Documentation/core-api/dma-attributes.rst | 9 +++ drivers/char/hw_random/virtio-rng.c | 3 + drivers/gpio/gpio-virtio.c | 15 ++-- drivers/scsi/virtio_scsi.c | 17 +++-- drivers/virtio/virtio_input.c | 5 +- drivers/virtio/virtio_ring.c | 83 ++++++++++++++++------- include/linux/dma-mapping.h | 20 ++++++ include/linux/virtio.h | 5 ++ kernel/dma/debug.c | 28 ++++++-- net/vmw_vsock/virtio_transport.c | 8 ++- 11 files changed, 205 insertions(+), 40 deletions(-)
Signature · 1 line
MST