Skip to content

transport: distinguish BAP mic and playback volumes

Pauli Virtanen linux-bluetooth 2 versions – Applied

Status from this message: This series was applied to bluetooth/bluez.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyApplied
  2. v13 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Drop the bt_bap_stream_is_server() function. The direction can be found based on bt_bap_stream_get_dir(), which for BAP Client indicates the remote endpoint, and for BAP Server the local endpoint direction.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2transport: clean up volume set/get for A2DP and VCPprofiles/audio/avrcp.c profiles/audio/media.c profiles/audio/media.h +4 more+105 -761 reply
2/2transport: distinguish BAP mic and playback volumesprofiles/audio/transport.c+17 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH BlueZ v2 0/2] transport: distinguish BAP mic and playback volumes

v2:
- Drop the bt_bap_stream_is_server() function. The direction can be found based on bt_bap_stream_get_dir(), which for BAP Client indicates the remote endpoint, and for BAP Server the local endpoint direction.

Its return value is a bit strange for broadcast, as lpac BCAST_SINK -> dir BCAST_SOURCE.

***

Currently we are confusing VCP and MICP volumes.

We are also mixing up AVRCP and VCP volumes.

As microphone volumes are commonly 100% and sound server may set them, we end up with spurious 100% playback volumes.

Fix this, and also do some cleanup of #ifdefs in the volume code.

Pauli Virtanen (2):
transport: clean up volume set/get for A2DP and VCP
transport: distinguish BAP mic and playback volumes

 profiles/audio/avrcp.c     |  10 +--
 profiles/audio/media.c     |   2 +-
 profiles/audio/media.h     |  10 +++
 profiles/audio/transport.c | 133 +++++++++++++++++++++----------------
 profiles/audio/transport.h |  10 +--
 profiles/audio/vcp.c       |  12 ++--
 profiles/audio/vcp.h       |  21 +++++-
 7 files changed, 121 insertions(+), 77 deletions(-)
Signature · 1 line
2.52.0

Read the cover letter in its thread