Skip to content

net: phy: realtek: simplify and reunify C22/C45 drivers

Daniel Golle lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 7 repliesIn review
  2. v15 patches 10 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: phy: realtek: support interrupt also for C22 variantsdrivers/net/phy/realtek/realtek_main.c+4 -00 replies
2/5net: phy: realtek: simplify C22 reg access via MDIO_MMD_VEND2drivers/net/phy/realtek/realtek_main.c+11 -07 replies
3/5net: phy: realtek: reunify C22 and C45 driversdrivers/net/phy/realtek/realtek_main.c+16 -560 replies
4/5net: phy: realtek: demystify PHYSR register locationdrivers/net/phy/realtek/realtek_main.c+13 -130 replies
5/5net: phy: realtek: simplify bogus paged operationsdrivers/net/phy/realtek/realtek_main.c+8 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/5] net: phy: realtek: simplify and reunify C22/C45 drivers

The RTL8221B PHY variants (VB-CG and VM-CG) were previously split into separate C22 and C45 driver instances to support copper SFP modules using the RollBall MDIO-over-I2C protocol, which only supports Clause-45 access. However, this split created significant code duplication and complexity.

Commit 8af2136e77989 ("net: phy: realtek: add helper RTL822X_VND2_C22_REG") exposed that RealTek PHYs map all standard Clause-22 registers into MDIO_MMD_VEND2 at offset 0xa400.

With commit 1850ec20d6e71 ("net: phy: realtek: use paged access for MDIO_MMD_VEND2 in C22 mode") it is now possible to access all MMD registers transparently, regardless of whether the PHY is accessed via C22 or C45 MDIO.

Further improve the translation logic for this register mapping, so a single unified driver works efficiently with both access methods, reducing code duplication.

The series also includes cleanup to remove unnecessary paged operations on registers that aren't actually affected by page selection.

Testing was done on RTL8211F and RTL8221B-VB-CG (the latter in both C22 and C45 modes).

Changes since initial submission:
- rebase on top of
"net: phy: realtek: add dummy PHY driver for RTL8127ATF"
- improve commit messages

Daniel Golle (5):
net: phy: realtek: support interrupt also for C22 variants
net: phy: realtek: simplify C22 reg access via MDIO_MMD_VEND2
net: phy: realtek: reunify C22 and C45 drivers
net: phy: realtek: demystify PHYSR register location
net: phy: realtek: simplify bogus paged operations

 drivers/net/phy/realtek/realtek_main.c | 124 ++++++++++---------------
 1 file changed, 48 insertions(+), 76 deletions(-)
Signature · 1 line
2.52.0