Skip to content

net: hinic3: Fix netif_queue_set_napi input parameters and code styles

Fan Gong linux-doc lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5hinic3: Fix netif_queue_set_napi queue_index parameter passing errordrivers/net/ethernet/huawei/hinic3/hinic3_irq.c+14 -90 replies
2/5hinic3: Fix code Style(remove empty lines between error handling)drivers/net/ethernet/huawei/hinic3/hinic3_cmdq.c drivers/net/ethernet/huawei/hinic3/hinic3_eqs.c drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +3 more+0 -160 replies
3/5hinic3: Remove redundant defensive codedrivers/net/ethernet/huawei/hinic3/hinic3_tx.c+0 -60 replies
4/5hinic3: Use array_size instead of multiplyingdrivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c+4 -20 replies
5/5hinic3: RQ use RQ_CTXT_PREF_CI_HI instead of SQ_CTXT_PREF_CI_HIdrivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c+5 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net v01 0/5] net: hinic3: Fix netif_queue_set_napi input parameters and code styles

This patchset provides netif_queue_set_napi bug fix and serveral code styles fixes to :

Fix netif_queue_set_napi queue_index parameter passing error. Remove empty lines between error handling.
Remove redundant defensive code.
Use array_size instead of multiplying.
Sq use SQ_CTXT_PREF_CI_HI to improve readability.

Thanks,
Fan gong

Fan Gong (5):
hinic3: Fix netif_queue_set_napi queue_index parameter passing error
hinic3: Fix code Style(remove empty lines between error handling)
hinic3: Remove redundant defensive code
hinic3: Use array_size instead of multiplying
hinic3: RQ use RQ_CTXT_PREF_CI_HI instead of SQ_CTXT_PREF_CI_HI

 .../net/ethernet/huawei/hinic3/hinic3_cmdq.c  |  3 ---
 .../net/ethernet/huawei/hinic3/hinic3_eqs.c   |  1 -
 .../net/ethernet/huawei/hinic3/hinic3_irq.c   | 23 +++++++++++--------
 .../net/ethernet/huawei/hinic3/hinic3_lld.c   |  5 ----
 .../net/ethernet/huawei/hinic3/hinic3_main.c  |  4 ----
 .../net/ethernet/huawei/hinic3/hinic3_mbox.c  |  2 --
 .../ethernet/huawei/hinic3/hinic3_nic_cfg.c   |  6 +++--
 .../ethernet/huawei/hinic3/hinic3_nic_io.c    |  6 ++++-
 .../net/ethernet/huawei/hinic3/hinic3_tx.c    |  7 ------
 9 files changed, 23 insertions(+), 34 deletions(-)

base-commit: 4515ec4ad58a37e70a9e1256c0b993958c9b7497

Signature · 1 line
2.43.0