Skip to content

btrfs: fix a return value and remove pointless labels and gotos

[email protected] linux-btrfs 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest19 patches 1 replyIn review
  2. v119 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19btrfs: qgroup: return correct error when deleting qgroup relation itemfs/btrfs/qgroup.c+3 -10 replies
2/19btrfs: remove pointless out labels from ioctl.cfs/btrfs/ioctl.c+17 -270 replies
3/19btrfs: remove pointless out labels from send.cfs/btrfs/send.c+33 -430 replies
4/19btrfs: remove pointless out labels from qgroup.cfs/btrfs/qgroup.c+10 -160 replies
5/19btrfs: remove pointless out labels from disk-io.cfs/btrfs/disk-io.c+22 -320 replies
6/19btrfs: remove pointless out labels from extent-tree.cfs/btrfs/extent-tree.c+10 -140 replies
7/19btrfs: remove pointless out labels from free-space-cache.cfs/btrfs/free-space-cache.c+12 -160 replies
8/19btrfs: remove pointless out labels from inode.cfs/btrfs/inode.c+9 -120 replies
9/19btrfs: remove pointless out labels from uuid-tree.cfs/btrfs/uuid-tree.c+6 -100 replies
10/19btrfs: remove out label in load_extent_tree_free()fs/btrfs/block-group.c+4 -60 replies
11/19btrfs: remove out_failed label in find_lock_delalloc_range()fs/btrfs/extent_io.c+2 -30 replies
12/19btrfs: remove out label in btrfs_csum_file_blocks()fs/btrfs/file-item.c+8 -80 replies
13/19btrfs: remove out label in btrfs_mark_extent_written()fs/btrfs/file.c+15 -150 replies
14/19btrfs: remove out label in lzo_decompress()fs/btrfs/lzo.c+7 -100 replies
15/19btrfs: remove out label in scrub_find_fill_first_stripe()fs/btrfs/scrub.c+4 -40 replies
16/19btrfs: remove out label in finish_verity()fs/btrfs/verity.c+5 -80 replies
17/19btrfs: remove out label in btrfs_check_rw_degradable()fs/btrfs/volumes.c+5 -70 replies
18/19btrfs: remove out label in btrfs_init_space_info()fs/btrfs/space-info.c+6 -70 replies
19/19btrfs: remove out label in btrfs_wait_for_commit()fs/btrfs/transaction.c+5 -40 replies

Reviews trailers per patch

None of the 19 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJohannes Thumshirn
SeriesR-b
1/19
2/19
3/19
4/19
5/19
6/19
7/19
8/19
9/19
10/19
11/19
12/19
13/19
14/19
15/19
16/19
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/19] btrfs: fix a return value and remove pointless labels and gotos

From: Filipe Manana <[email protected]>

Remove pointless labels and gotos that can be replaced with a single "return ret" or "return -SOMEERROR", making the code shorter and more straighforward to follow and to not leave such examples for people to copy and keep repeating it. The first patch fixes a bug in an error path where we can end up returning success (0) instead of an error.

V2: Fix a couple wrong return values in send.c and lzo.c.

Filipe Manana (19):
btrfs: qgroup: return correct error when deleting qgroup relation item
btrfs: remove pointless out labels from ioctl.c
btrfs: remove pointless out labels from send.c
btrfs: remove pointless out labels from qgroup.c
btrfs: remove pointless out labels from disk-io.c
btrfs: remove pointless out labels from extent-tree.c
btrfs: remove pointless out labels from free-space-cache.c
btrfs: remove pointless out labels from inode.c
btrfs: remove pointless out labels from uuid-tree.c
btrfs: remove out label in load_extent_tree_free()
btrfs: remove out_failed label in find_lock_delalloc_range()
btrfs: remove out label in btrfs_csum_file_blocks()
btrfs: remove out label in btrfs_mark_extent_written()
btrfs: remove out label in lzo_decompress()
btrfs: remove out label in scrub_find_fill_first_stripe()
btrfs: remove out label in finish_verity()
btrfs: remove out label in btrfs_check_rw_degradable()
btrfs: remove out label in btrfs_init_space_info()
btrfs: remove out label in btrfs_wait_for_commit()

 fs/btrfs/block-group.c      | 10 ++---
 fs/btrfs/disk-io.c          | 54 +++++++++++---------------
 fs/btrfs/extent-tree.c      | 24 +++++-------
 fs/btrfs/extent_io.c        |  5 +--
 fs/btrfs/file-item.c        | 16 ++++----
 fs/btrfs/file.c             | 30 +++++++--------
 fs/btrfs/free-space-cache.c | 28 ++++++--------
 fs/btrfs/inode.c            | 21 +++++-----
 fs/btrfs/ioctl.c            | 44 +++++++++------------
 fs/btrfs/lzo.c              | 17 ++++-----
 fs/btrfs/qgroup.c           | 22 +++++------
 fs/btrfs/scrub.c            |  8 ++--
 fs/btrfs/send.c             | 76 ++++++++++++++++---------------------
 fs/btrfs/space-info.c       | 13 +++----
 fs/btrfs/transaction.c      |  9 +++--
 fs/btrfs/uuid-tree.c        | 16 +++-----
 fs/btrfs/verity.c           | 13 +++----
 fs/btrfs/volumes.c          | 12 +++---
 18 files changed, 179 insertions(+), 239 deletions(-)
Signature · 1 line
2.47.2