Skip to content

net: hinic3: Fix code styles

Fan Gong linux-doc lkml netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesApplied 4/4
  2. v24 patches 3 repliesSuperseded

Patches in v3 All 4 applied

#Subject and filesSizeRepliesApplied
1/4hinic3: Fix code Style(remove empty lines between error handling)drivers/net/ethernet/huawei/hinic3/hinic3_cmdq.c drivers/net/ethernet/huawei/hinic3/hinic3_eqs.c drivers/net/ethernet/huawei/hinic3/hinic3_lld.c +3 more+0 -161 replyApplied
2/4hinic3: Remove defensive txq_num checkdrivers/net/ethernet/huawei/hinic3/hinic3_tx.c+0 -60 repliesApplied
3/4hinic3: Use array_size instead of multiplyingdrivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c+4 -21 replyApplied
4/4hinic3: RQ use RQ_CTXT_PREF_CI_HI instead of SQ_CTXT_PREF_CI_HIdrivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c+5 -10 repliesApplied

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchJoe Damato
1/4
2/4
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v03 0/4] net: hinic3: Fix code styles

This patchset provides 4 code styles fixes:

Remove empty lines between error handling. Remove defensive txq_num check.
Use array_size instead of multiplying.
SQ use SQ_CTXT_PREF_CI_HI to improve readability.

Changes:

PATCH V01: https://lore.kernel.org/netdev/[email protected]/

PATCH V02: https://lore.kernel.org/netdev/[email protected]/
* Send "Fix netif_queue_set_napi queue_index parameter passing error" to net (Jakub Kicinski)

PATCH V03:
* Modify commit description to be more accurate and clear (Simon Horman)

Fan Gong (4):
hinic3: Fix code Style(remove empty lines between error handling)
hinic3: Remove defensive txq_num check
hinic3: Use array_size instead of multiplying
hinic3: RQ use RQ_CTXT_PREF_CI_HI instead of SQ_CTXT_PREF_CI_HI

 drivers/net/ethernet/huawei/hinic3/hinic3_cmdq.c    | 3 ---
 drivers/net/ethernet/huawei/hinic3/hinic3_eqs.c     | 1 -
 drivers/net/ethernet/huawei/hinic3/hinic3_lld.c     | 5 -----
 drivers/net/ethernet/huawei/hinic3/hinic3_main.c    | 4 ----
 drivers/net/ethernet/huawei/hinic3/hinic3_mbox.c    | 2 --
 drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c | 6 ++++--
 drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c  | 6 +++++-
 drivers/net/ethernet/huawei/hinic3/hinic3_tx.c      | 7 -------
 8 files changed, 9 insertions(+), 25 deletions(-)

base-commit: 4515ec4ad58a37e70a9e1256c0b993958c9b7497

Signature · 1 line
2.43.0