Skip to content

i3c: dw-i3c-master: scoped spinlock guards and SIR reject fix

[email protected] linux-i3c lkml 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 2 repliesApplied
  2. v32 patches 2 repliesSuperseded
  3. v22 patches 2 repliesSuperseded

Changes in v4 from the cover letter

- Dropped unused DYN_ADDR_LO_BITS definition.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/2i3c: dw-i3c-master: convert spinlock usage to scoped guardsdrivers/i3c/master/dw-i3c-master.c+8 -260 replies
2/2i3c: dw-i3c-master: fix SIR reject bit mapping for dynamic addressesdrivers/i3c/master/dw-i3c-master.c+23 -21 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchFrank Li
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] i3c: dw-i3c-master: scoped spinlock guards and SIR reject fix

From: Adrian Ng Ho Yin <[email protected]>

This patchset replaces open-coded spin_lock_irqsave()/spin_unlock_irqrestore() pairs with scoped spinlock guards to reduce boilerplate and ensure correct lock release on scope exit.

In a subsequent patch it fixes the SIR reject bit mapping used for IBI handling. The IBI_SIR_REQ_REJECT register is indexed by a folded form of the 7-bit dynamic address, but the driver currently uses the device table index. This can result in IBIs being rejected or accepted for the wrong device. The patch derives the bit index directly from the dynamic address as defined by the controller.

---
changelog
v3->v4:
- Dropped unused DYN_ADDR_LO_BITS definition.

v2->v3:
- Update guard function call in dw_i3c_master_free_ibi to use scoped_guard to avoid i3c_generic_ibi_free_pool happening under spinlock.
- Update get_ibi_sir_bit_index to use FIELD_GET and drop DYN_ADDR_LO_BITS definition.

v1->v2:
- Add implementation to use scoped spinlock guards to ensure correct lock release.
- Update remove DYN_ADDR_HI_BITS macro definition and update MASK to use index directly.
---

Adrian Ng Ho Yin (2):
i3c: dw-i3c-master: convert spinlock usage to scoped guards
i3c: dw-i3c-master: fix SIR reject bit mapping for dynamic addresses

 drivers/i3c/master/dw-i3c-master.c | 59 ++++++++++++++++--------------
 1 file changed, 31 insertions(+), 28 deletions(-)
Signature · 1 line
2.49.GIT