Skip to content

xdiff: Remove unneeded members from xrecord_t and xdlclass_t

Phillip Wood git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xdiff: remove "line_hash" field from xrecord_txdiff/xprepare.c xdiff/xtypes.h+7 -60 replies
2/2xdiff: remove unused data from xdlclass_txdiff/xprepare.c+5 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] xdiff: Remove unneeded members from xrecord_t and xdlclass_t

From: Phillip Wood <[email protected]>

This series has a couple of cleanups on top of 'en/xdiff-cleanup-2' that reduce the sizes of the xrecord_t and xdlclass_t. Unfortunately they conflict with 'en/xdiff-cleanup-3' in seen, in particular with db8a50ca6b9 (xdiff: don't waste time guessing the number of lines, 2026-01-02). I'm not particularly convinced that moving the call to xdl_classify_record() out of xdl_prepare_ctx() in that commit is a good idea, but if we decide that we do want to stop classifying lines in xdl_prepare_ctx() we can start passing the hashes out in a separate array rather than wasting space in xrecord_t.

Base-Commit: 1faf5b085a171f9ba9a6d7a446e0de16acccb1dc
Published-As: https://github.com/phillipwood/git/releases/tag/pw%2Fxdiff-cleanup-xrecord_t-and-xdlclass_t%2Fv1
View-Changes-At: https://github.com/phillipwood/git/compare/1faf5b085...0d251dfba
Fetch-It-Via: git fetch https://github.com/phillipwood/git pw/xdiff-cleanup-xrecord_t-and-xdlclass_t/v1

Phillip Wood (2):
xdiff: remove "line_hash" field from xrecord_t
xdiff: remove unused data from xdlclass_t

 xdiff/xprepare.c | 20 ++++++++++++--------
 xdiff/xtypes.h   |  1 -
 2 files changed, 12 insertions(+), 9 deletions(-)
Signature · 1 line
2.52.0.362.g884e03848a9