Cleanups for ixgbe, i40e, iavf, and ice PMD's
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest26 patches 1 replyIn review
- v826 patches 0 repliesSuperseded
- v727 patches 0 repliesSuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 27 patches | 2 replies | Superseded | |
| v5 | 27 patches | 8 replies | Superseded | |
| v4 | 27 patches | 36 replies | Superseded | |
| v3 | 27 patches | 15 replies | Superseded | |
| v2 | 26 patches | 0 replies | Superseded | |
| v1 | 12 patches | 1 reply | Superseded |
Changes in v9 from the cover letter
- Fixed testing failures in IAVF on account of "wrong" adminq buffer sizes
Patches in v9 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/26 | net/ixgbe: remove MAC type check macrosdrivers/ drivers/ | +17 | 0 replies | |
| 2/26 | net/ixgbe: remove security-related ifdeferydrivers/ drivers/ drivers/ +3 more | +0 | 0 replies | |
| 3/26 | net/ixgbe: split security and ntuple filtersdrivers/ | +122 | 0 replies | |
| 4/26 | net/i40e: get rid of global filter variablesdrivers/ drivers/ | +68 | 0 replies | |
| 5/26 | net/i40e: make default RSS key globaldrivers/ drivers/ drivers/ | +30 | 0 replies | |
| 6/26 | net/i40e: use unsigned types for queue comparisonsdrivers/ drivers/ drivers/ | +12 | 0 replies | |
| 7/26 | net/i40e: use proper flex len definedrivers/ | +1 | 0 replies | |
| 8/26 | net/i40e: remove global pattern variabledrivers/ | +10 | 0 replies | |
| 9/26 | net/i40e: avoid rte malloc in tunnel setdrivers/ | +53 | 0 replies | |
| 10/26 | net/i40e: avoid rte malloc in RSS RETA operationsdrivers/ | +4 | 0 replies | |
| 11/26 | net/i40e: avoid rte malloc in MAC/VLAN filteringdrivers/ drivers/ | +65 | 0 replies | |
| 12/26 | net/i40e: avoid rte malloc in VF resource queriesdrivers/ | +7 | 0 replies | |
| 13/26 | net/i40e: avoid rte malloc in adminq operationsdrivers/ | +3 | 0 replies | |
| 14/26 | net/i40e: avoid rte malloc in DDP package handlingdrivers/ | +8 | 0 replies | |
| 15/26 | net/i40e: avoid rte malloc in DDP ptype handlingdrivers/ | +12 | 0 replies | |
| 16/26 | net/iavf: remove remnants of pipeline modedrivers/ drivers/ drivers/ +2 more | +0 | 0 replies | |
| 17/26 | net/iavf: decouple hash uninit from parser uninitdrivers/ drivers/ drivers/ | +12 | 0 replies | |
| 18/26 | net/iavf: avoid rte malloc in VF mailbox for IPsecdrivers/ | +28 | 0 replies | |
| 19/26 | net/iavf: avoid rte malloc in RSS configurationdrivers/ drivers/ | +6 | 0 replies | |
| 20/26 | net/iavf: avoid rte malloc in MAC address operationsdrivers/ | +35 | 0 replies | |
| 21/26 | net/iavf: avoid rte malloc in queue operationsdrivers/ drivers/ drivers/ | +119 | 0 replies | |
| 22/26 | net/iavf: avoid rte malloc in irq map configdrivers/ drivers/ drivers/ | +83 | 0 replies | |
| 23/26 | net/ice: avoid rte malloc in RSS RETA operationsdrivers/ drivers/ | +8 | 0 replies | |
| 24/26 | net/ice: avoid rte malloc in MAC address operationsdrivers/ | +8 | 0 replies | |
| 25/26 | net/ice: avoid rte malloc in raw pattern parsingdrivers/ drivers/ | +12 | 0 replies | |
| 26/26 | net/ice: avoid rte malloc in flow pattern matchdrivers/ drivers/ drivers/ +2 more | +17 | 0 replies |
Reviews trailers per patch
16 of 26 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Medvedkin | Bruce Richardson |
|---|---|---|
| Series | Series-Acked-by | |
| 1/26 | A-b | |
| 2/26 | A-b | |
| 3/26 | A-b | |
| 4/26 | A-b | |
| 5/26 | A-b | |
| 6/26 | A-b | |
| 7/26 | A-b | |
| 8/26 | A-b | |
| 9/26 | A-b | |
| 10/26 | ||
| 11/26 | ||
| 12/26 | A-b | |
| 13/26 | A-b | |
| 14/26 | A-b | |
| 15/26 | ||
| 16/26 | ||
| 17/26 | A-b | |
| 18/26 | ||
| 19/26 | ||
| 20/26 | ||
| 21/26 | ||
| 22/26 | ||
| 23/26 | A-b | |
| 24/26 | A-b | |
| 25/26 | A-b | |
| 26/26 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v9 00/26] Cleanups for ixgbe, i40e, iavf, and ice PMD's
This patchset is an assortment of cleanups for ixgbe, i40e, iavf, and ice PMD.
IXGBE:
- Remove unnecessary macros and #ifdef's
- Disentangle unrelated flow API code paths
I40E:
- Get rid of global variables and unnecessary allocations
- Reduce code duplication around default RSS keys
- Use more appropriate integer types and definitions
IAVF:
- Remove dead code
- Remove unnecessary allocations
- Separate RSS uninit from hash flow parser uninit
ICE:
- Remove unnecessary allocations
This is done in preparation for further rework.
Note that this patchset depends on driver bug fix patchset [1] as well as an IPsec struct fix [2] (both already integrated into next-net-intel).
[1] https://patches.dpdk.org/project/dpdk/list/?series=37350
[2] https://patches.dpdk.org/project/dpdk/patch/c87355f75826ec90a506dc8d4548e3f6af2b7e93.1771581658.git.anatoly.burakov@intel.com/
v1 -> v2:
- Added more cleanups around rte_malloc usage
v2 -> v3:
- Reworded some commit messages
- Added a new patch for ICE
- Rebased on latest bug fix patches
v3 -> v4:
- Rebased on latest bugfix patchset
v4 -> v5:
- Adjusted typing for queue size
- Fixed missing zero initializations for stack allocations
v5 -> v6:
- Addressed feedback for v3, v4, and v5
- Changed more allocations to be stack based
- Reworked queue and IRQ map related i40e patches for better logic
v6 -> v7:
- Fixed offset logic in IRQ map
- (Hopefully) fixed zero-sized array initialization error for MSVC
v7 -> v8:
- Reverted to using calloc for IPsec patch because MSVC doesn't like stack-initialized structs with zero-sized array members
- Merged two IPsec patches together
v8 -> v9:
- Fixed testing failures in IAVF on account of "wrong" adminq buffer sizes
Anatoly Burakov (26):
net/ixgbe: remove MAC type check macros net/ixgbe: remove security-related ifdefery net/ixgbe: split security and ntuple filters net/i40e: get rid of global filter variables net/i40e: make default RSS key global net/i40e: use unsigned types for queue comparisons net/i40e: use proper flex len define net/i40e: remove global pattern variable net/i40e: avoid rte malloc in tunnel set net/i40e: avoid rte malloc in RSS RETA operations net/i40e: avoid rte malloc in MAC/VLAN filtering net/i40e: avoid rte malloc in VF resource queries net/i40e: avoid rte malloc in adminq operations net/i40e: avoid rte malloc in DDP package handling net/i40e: avoid rte malloc in DDP ptype handling net/iavf: remove remnants of pipeline mode net/iavf: decouple hash uninit from parser uninit net/iavf: avoid rte malloc in VF mailbox for IPsec net/iavf: avoid rte malloc in RSS configuration net/iavf: avoid rte malloc in MAC address operations net/iavf: avoid rte malloc in queue operations net/iavf: avoid rte malloc in irq map config net/ice: avoid rte malloc in RSS RETA operations net/ice: avoid rte malloc in MAC address operations net/ice: avoid rte malloc in raw pattern parsing net/ice: avoid rte malloc in flow pattern match
drivers/net/intel/i40e/i40e_ethdev.c | 370 +++++++--------- drivers/net/intel/i40e/i40e_ethdev.h | 26 +- drivers/net/intel/i40e/i40e_flow.c | 147 +++---- drivers/net/intel/i40e/i40e_hash.c | 27 +- drivers/net/intel/i40e/i40e_hash.h | 3 + drivers/net/intel/i40e/i40e_pf.c | 26 +- drivers/net/intel/i40e/rte_pmd_i40e.c | 60 +-- drivers/net/intel/iavf/iavf.h | 7 +- drivers/net/intel/iavf/iavf_ethdev.c | 37 +- drivers/net/intel/iavf/iavf_fdir.c | 1 - drivers/net/intel/iavf/iavf_fsub.c | 1 - drivers/net/intel/iavf/iavf_generic_flow.h | 15 - drivers/net/intel/iavf/iavf_hash.c | 13 +- drivers/net/intel/iavf/iavf_ipsec_crypto.c | 61 ++- drivers/net/intel/iavf/iavf_vchnl.c | 432 ++++++++++--------- drivers/net/intel/ice/ice_acl_filter.c | 3 +- drivers/net/intel/ice/ice_dcf_ethdev.c | 26 +- drivers/net/intel/ice/ice_ethdev.c | 29 +- drivers/net/intel/ice/ice_fdir_filter.c | 19 +- drivers/net/intel/ice/ice_generic_flow.c | 15 +- drivers/net/intel/ice/ice_hash.c | 13 +- drivers/net/intel/ice/ice_switch_filter.c | 5 +- drivers/net/intel/ixgbe/ixgbe_ethdev.c | 8 - drivers/net/intel/ixgbe/ixgbe_ethdev.h | 16 - drivers/net/intel/ixgbe/ixgbe_flow.c | 228 ++++++---- drivers/net/intel/ixgbe/ixgbe_rxtx.c | 26 -- drivers/net/intel/ixgbe/ixgbe_rxtx.h | 2 - drivers/net/intel/ixgbe/ixgbe_rxtx_vec_sse.c | 6 - 28 files changed, 740 insertions(+), 882 deletions(-)
Signature · 1 line
2.47.3