Skip to content

Cleanups for ixgbe, i40e, iavf, and ice PMD's

Anatoly Burakov dpdk-dev 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest26 patches 1 replyIn review
  2. v826 patches 0 repliesSuperseded
  3. v727 patches 0 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v627 patches2 repliesSuperseded
v527 patches8 repliesSuperseded
v427 patches36 repliesSuperseded
v327 patches15 repliesSuperseded
v226 patches0 repliesSuperseded
v112 patches1 replySuperseded

Changes in v9 from the cover letter

- Fixed testing failures in IAVF on account of "wrong" adminq buffer sizes

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26net/ixgbe: remove MAC type check macrosdrivers/net/intel/ixgbe/ixgbe_ethdev.h drivers/net/intel/ixgbe/ixgbe_flow.c+17 -150 replies
2/26net/ixgbe: remove security-related ifdeferydrivers/net/intel/ixgbe/ixgbe_ethdev.c drivers/net/intel/ixgbe/ixgbe_ethdev.h drivers/net/intel/ixgbe/ixgbe_flow.c +3 more+0 -520 replies
3/26net/ixgbe: split security and ntuple filtersdrivers/net/intel/ixgbe/ixgbe_flow.c+122 -800 replies
4/26net/i40e: get rid of global filter variablesdrivers/net/intel/i40e/i40e_ethdev.h drivers/net/intel/i40e/i40e_flow.c+68 -650 replies
5/26net/i40e: make default RSS key globaldrivers/net/intel/i40e/i40e_ethdev.c drivers/net/intel/i40e/i40e_hash.c drivers/net/intel/i40e/i40e_hash.h+30 -180 replies
6/26net/i40e: use unsigned types for queue comparisonsdrivers/net/intel/i40e/i40e_ethdev.c drivers/net/intel/i40e/i40e_ethdev.h drivers/net/intel/i40e/i40e_hash.c+12 -110 replies
7/26net/i40e: use proper flex len definedrivers/net/intel/i40e/i40e_ethdev.h+1 -10 replies
8/26net/i40e: remove global pattern variabledrivers/net/intel/i40e/i40e_flow.c+10 -200 replies
9/26net/i40e: avoid rte malloc in tunnel setdrivers/net/intel/i40e/i40e_ethdev.c+53 -710 replies
10/26net/i40e: avoid rte malloc in RSS RETA operationsdrivers/net/intel/i40e/i40e_ethdev.c+4 -210 replies
11/26net/i40e: avoid rte malloc in MAC/VLAN filteringdrivers/net/intel/i40e/i40e_ethdev.c drivers/net/intel/i40e/rte_pmd_i40e.c+65 -870 replies
12/26net/i40e: avoid rte malloc in VF resource queriesdrivers/net/intel/i40e/i40e_pf.c+7 -190 replies
13/26net/i40e: avoid rte malloc in adminq operationsdrivers/net/intel/i40e/i40e_ethdev.c+3 -70 replies
14/26net/i40e: avoid rte malloc in DDP package handlingdrivers/net/intel/i40e/rte_pmd_i40e.c+8 -350 replies
15/26net/i40e: avoid rte malloc in DDP ptype handlingdrivers/net/intel/i40e/i40e_ethdev.c+12 -310 replies
16/26net/iavf: remove remnants of pipeline modedrivers/net/intel/iavf/iavf_fdir.c drivers/net/intel/iavf/iavf_fsub.c drivers/net/intel/iavf/iavf_generic_flow.h +2 more+0 -190 replies
17/26net/iavf: decouple hash uninit from parser uninitdrivers/net/intel/iavf/iavf.h drivers/net/intel/iavf/iavf_ethdev.c drivers/net/intel/iavf/iavf_hash.c+12 -40 replies
18/26net/iavf: avoid rte malloc in VF mailbox for IPsecdrivers/net/intel/iavf/iavf_ipsec_crypto.c+28 -320 replies
19/26net/iavf: avoid rte malloc in RSS configurationdrivers/net/intel/iavf/iavf_ethdev.c drivers/net/intel/iavf/iavf_vchnl.c+6 -60 replies
20/26net/iavf: avoid rte malloc in MAC address operationsdrivers/net/intel/iavf/iavf_vchnl.c+35 -530 replies
21/26net/iavf: avoid rte malloc in queue operationsdrivers/net/intel/iavf/iavf.h drivers/net/intel/iavf/iavf_ethdev.c drivers/net/intel/iavf/iavf_vchnl.c+119 -1140 replies
22/26net/iavf: avoid rte malloc in irq map configdrivers/net/intel/iavf/iavf.h drivers/net/intel/iavf/iavf_ethdev.c drivers/net/intel/iavf/iavf_vchnl.c+83 -560 replies
23/26net/ice: avoid rte malloc in RSS RETA operationsdrivers/net/intel/ice/ice_dcf_ethdev.c drivers/net/intel/ice/ice_ethdev.c+8 -250 replies
24/26net/ice: avoid rte malloc in MAC address operationsdrivers/net/intel/ice/ice_dcf_ethdev.c+8 -140 replies
25/26net/ice: avoid rte malloc in raw pattern parsingdrivers/net/intel/ice/ice_fdir_filter.c drivers/net/intel/ice/ice_hash.c+12 -120 replies
26/26net/ice: avoid rte malloc in flow pattern matchdrivers/net/intel/ice/ice_acl_filter.c drivers/net/intel/ice/ice_fdir_filter.c drivers/net/intel/ice/ice_generic_flow.c +2 more+17 -140 replies

Reviews trailers per patch

16 of 26 patches have a Reviewed-by or Acked-by.

PatchVladimir MedvedkinBruce Richardson
SeriesSeries-Acked-by
1/26A-b
2/26A-b
3/26A-b
4/26A-b
5/26A-b
6/26A-b
7/26A-b
8/26A-b
9/26A-b
10/26
11/26
12/26A-b
13/26A-b
14/26A-b
15/26
16/26
17/26A-b
18/26
19/26
20/26
21/26
22/26
23/26A-b
24/26A-b
25/26A-b
26/26

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 00/26] Cleanups for ixgbe, i40e, iavf, and ice PMD's

This patchset is an assortment of cleanups for ixgbe, i40e, iavf, and ice PMD.

IXGBE:

- Remove unnecessary macros and #ifdef's
- Disentangle unrelated flow API code paths

I40E:

- Get rid of global variables and unnecessary allocations
- Reduce code duplication around default RSS keys
- Use more appropriate integer types and definitions

IAVF:

- Remove dead code
- Remove unnecessary allocations
- Separate RSS uninit from hash flow parser uninit

ICE:

- Remove unnecessary allocations

This is done in preparation for further rework.

Note that this patchset depends on driver bug fix patchset [1] as well as an IPsec struct fix [2] (both already integrated into next-net-intel).

[1] https://patches.dpdk.org/project/dpdk/list/?series=37350
[2] https://patches.dpdk.org/project/dpdk/patch/c87355f75826ec90a506dc8d4548e3f6af2b7e93.1771581658.git.anatoly.burakov@intel.com/

v1 -> v2:
- Added more cleanups around rte_malloc usage

v2 -> v3:
- Reworded some commit messages
- Added a new patch for ICE
- Rebased on latest bug fix patches

v3 -> v4:
- Rebased on latest bugfix patchset

v4 -> v5:
- Adjusted typing for queue size
- Fixed missing zero initializations for stack allocations

v5 -> v6:
- Addressed feedback for v3, v4, and v5
- Changed more allocations to be stack based
- Reworked queue and IRQ map related i40e patches for better logic

v6 -> v7:
- Fixed offset logic in IRQ map
- (Hopefully) fixed zero-sized array initialization error for MSVC

v7 -> v8:
- Reverted to using calloc for IPsec patch because MSVC doesn't like stack-initialized structs with zero-sized array members
- Merged two IPsec patches together

v8 -> v9:
- Fixed testing failures in IAVF on account of "wrong" adminq buffer sizes

Anatoly Burakov (26):
net/ixgbe: remove MAC type check macros net/ixgbe: remove security-related ifdefery net/ixgbe: split security and ntuple filters net/i40e: get rid of global filter variables net/i40e: make default RSS key global net/i40e: use unsigned types for queue comparisons net/i40e: use proper flex len define net/i40e: remove global pattern variable net/i40e: avoid rte malloc in tunnel set net/i40e: avoid rte malloc in RSS RETA operations net/i40e: avoid rte malloc in MAC/VLAN filtering net/i40e: avoid rte malloc in VF resource queries net/i40e: avoid rte malloc in adminq operations net/i40e: avoid rte malloc in DDP package handling net/i40e: avoid rte malloc in DDP ptype handling net/iavf: remove remnants of pipeline mode net/iavf: decouple hash uninit from parser uninit net/iavf: avoid rte malloc in VF mailbox for IPsec net/iavf: avoid rte malloc in RSS configuration net/iavf: avoid rte malloc in MAC address operations net/iavf: avoid rte malloc in queue operations net/iavf: avoid rte malloc in irq map config net/ice: avoid rte malloc in RSS RETA operations net/ice: avoid rte malloc in MAC address operations net/ice: avoid rte malloc in raw pattern parsing net/ice: avoid rte malloc in flow pattern match

 drivers/net/intel/i40e/i40e_ethdev.c         | 370 +++++++---------
 drivers/net/intel/i40e/i40e_ethdev.h         |  26 +-
 drivers/net/intel/i40e/i40e_flow.c           | 147 +++----
 drivers/net/intel/i40e/i40e_hash.c           |  27 +-
 drivers/net/intel/i40e/i40e_hash.h           |   3 +
 drivers/net/intel/i40e/i40e_pf.c             |  26 +-
 drivers/net/intel/i40e/rte_pmd_i40e.c        |  60 +--
 drivers/net/intel/iavf/iavf.h                |   7 +-
 drivers/net/intel/iavf/iavf_ethdev.c         |  37 +-
 drivers/net/intel/iavf/iavf_fdir.c           |   1 -
 drivers/net/intel/iavf/iavf_fsub.c           |   1 -
 drivers/net/intel/iavf/iavf_generic_flow.h   |  15 -
 drivers/net/intel/iavf/iavf_hash.c           |  13 +-
 drivers/net/intel/iavf/iavf_ipsec_crypto.c   |  61 ++-
 drivers/net/intel/iavf/iavf_vchnl.c          | 432 ++++++++++---------
 drivers/net/intel/ice/ice_acl_filter.c       |   3 +-
 drivers/net/intel/ice/ice_dcf_ethdev.c       |  26 +-
 drivers/net/intel/ice/ice_ethdev.c           |  29 +-
 drivers/net/intel/ice/ice_fdir_filter.c      |  19 +-
 drivers/net/intel/ice/ice_generic_flow.c     |  15 +-
 drivers/net/intel/ice/ice_hash.c             |  13 +-
 drivers/net/intel/ice/ice_switch_filter.c    |   5 +-
 drivers/net/intel/ixgbe/ixgbe_ethdev.c       |   8 -
 drivers/net/intel/ixgbe/ixgbe_ethdev.h       |  16 -
 drivers/net/intel/ixgbe/ixgbe_flow.c         | 228 ++++++----
 drivers/net/intel/ixgbe/ixgbe_rxtx.c         |  26 --
 drivers/net/intel/ixgbe/ixgbe_rxtx.h         |   2 -
 drivers/net/intel/ixgbe/ixgbe_rxtx_vec_sse.c |   6 -
 28 files changed, 740 insertions(+), 882 deletions(-)
Signature · 1 line
2.47.3