Add common flow attr/action parsing infrastructure to Intel PMD's
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest27 patches 1 replyIn review
- v627 patches 2 repliesSuperseded
- v527 patches 9 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 26 patches | 0 replies | Superseded | |
| v3 | 29 patches | 4 replies | Superseded | |
| v2 | 25 patches | 1 reply | Superseded | |
| v1 | 25 patches | 0 replies | Superseded |
Changes in v7 from the cover letter
- Fail on empty action list before calling into user callbacks
- Remove empty code
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/27 | build: add build defines for component name and classdrivers/ lib/ | +4 | 0 replies | |
| 2/27 | eal/common: add token concatenation macrolib/ | +4 | 0 replies | |
| 3/27 | net/intel/common: add common flow action parsingdrivers/ drivers/ | +324 | 0 replies | |
| 4/27 | net/intel/common: add common flow attr validationdrivers/ | +70 | 0 replies | |
| 5/27 | net/ixgbe: use common checks in ethertype filterdrivers/ | +73 | 0 replies | |
| 6/27 | net/ixgbe: use common checks in syn filterdrivers/ | +32 | 0 replies | |
| 7/27 | net/ixgbe: use common checks in L2 tunnel filterdrivers/ | +48 | 0 replies | |
| 8/27 | net/ixgbe: use common checks in ntuple filterdrivers/ | +36 | 0 replies | |
| 9/27 | net/ixgbe: use common checks in security filterdrivers/ | +22 | 0 replies | |
| 10/27 | net/ixgbe: use common checks in FDIR filtersdrivers/ | +138 | 0 replies | |
| 11/27 | net/ixgbe: use common checks in RSS filterdrivers/ | +79 | 0 replies | |
| 12/27 | net/i40e: use common flow attribute checksdrivers/ drivers/ | +10 | 0 replies | |
| 13/27 | net/i40e: refactor RSS flow parameter checksdrivers/ drivers/ drivers/ | +275 | 0 replies | |
| 14/27 | net/i40e: use common action checks for ethertypedrivers/ | +24 | 0 replies | |
| 15/27 | net/i40e: use common action checks for FDIRdrivers/ | +76 | 0 replies | |
| 16/27 | net/i40e: use common action checks for tunneldrivers/ | +48 | 0 replies | |
| 17/27 | net/iavf: use common flow attribute checksdrivers/ drivers/ drivers/ +3 more | +43 | 0 replies | |
| 18/27 | net/iavf: use common action checks for IPsecdrivers/ | +15 | 0 replies | |
| 19/27 | net/iavf: use common action checks for hashdrivers/ | +72 | 0 replies | |
| 20/27 | net/iavf: use common action checks for FDIRdrivers/ | +158 | 0 replies | |
| 21/27 | net/iavf: use common action checks for fsubdrivers/ drivers/ | +101 | 0 replies | |
| 22/27 | net/iavf: use common action checks for flow querydrivers/ | +16 | 0 replies | |
| 23/27 | net/ice: use common flow attribute checksdrivers/ drivers/ drivers/ +3 more | +48 | 0 replies | |
| 24/27 | net/ice: use common action checks for hashdrivers/ | +95 | 0 replies | |
| 25/27 | net/ice: use common action checks for FDIRdrivers/ | +204 | 0 replies | |
| 26/27 | net/ice: use common action checks for switchdrivers/ | +185 | 0 replies | |
| 27/27 | net/ice: use common action checks for ACLdrivers/ | +84 | 0 replies |
Reviews trailers per patch
26 of 27 patches have a Reviewed-by or Acked-by.
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 00/27] Add common flow attr/action parsing infrastructure to Intel PMD's
This patchset introduces common flow attr/action checking infrastructure to some Intel PMD's (IXGBE, I40E, IAVF, and ICE). The aim is to reduce code duplication, simplify implementation of new parsers/verification of existing ones, and make action/attr handling more consistent across drivers.
v7:
- Fail on empty action list before calling into user callbacks
- Remove empty code
v6:
- Increase max number of actions to 32
- Add missing flow item types from list of types needing conf
- Improved egress/ingress handling
- ixgbe: allow mark and drop combination of actions
- ixgbe: fix set-then-reset when initializing rules for fdir engine
v5:
- Add missing patch for component/class name compile time constant
- Fixed missing RSS queue contiguousness checks
v4:
- First few commits were integrated as part of a different patchset
- Added more logging to common infrastructure
- RSS validation now allows discontiguous queue lists by default
- Fixed some checks being too stringent and failing common validation
v3:
- Rebase on latest next-net-intel
- Added 4 new commits that have to do with not using rte_eth_dev in rte_flow
- Converted the remaining commits to use adapter structures everywhere
- Minor fixes in how return values are handled
- Fixed incorrect check in i40e RSS validation
v2:
- Rebase on latest main
- Now depends on series 37585 [1]
[1] https://patches.dpdk.org/project/dpdk/list/?series=37585
Anatoly Burakov (21):
eal/common: add token concatenation macro net/intel/common: add common flow action parsing net/intel/common: add common flow attr validation net/ixgbe: use common checks in ethertype filter net/ixgbe: use common checks in syn filter net/ixgbe: use common checks in L2 tunnel filter net/ixgbe: use common checks in ntuple filter net/ixgbe: use common checks in security filter net/ixgbe: use common checks in FDIR filters net/ixgbe: use common checks in RSS filter net/i40e: use common flow attribute checks net/i40e: refactor RSS flow parameter checks net/i40e: use common action checks for ethertype net/i40e: use common action checks for FDIR net/i40e: use common action checks for tunnel net/iavf: use common flow attribute checks net/iavf: use common action checks for IPsec net/iavf: use common action checks for hash net/iavf: use common action checks for FDIR net/iavf: use common action checks for fsub net/iavf: use common action checks for flow query
Bruce Richardson (1):
build: add build defines for component name and class
Vladimir Medvedkin (5):
net/ice: use common flow attribute checks
net/ice: use common action checks for hash
net/ice: use common action checks for FDIR
net/ice: use common action checks for switch
net/ice: use common action checks for ACL
drivers/meson.build | 2 + drivers/net/intel/common/flow_check.h | 354 ++++++ drivers/net/intel/common/log.h | 40 + drivers/net/intel/i40e/i40e_ethdev.h | 1 - drivers/net/intel/i40e/i40e_flow.c | 433 +++----- drivers/net/intel/i40e/i40e_hash.c | 438 +++++--- drivers/net/intel/i40e/i40e_hash.h | 2 +- drivers/net/intel/iavf/iavf_fdir.c | 368 +++---- drivers/net/intel/iavf/iavf_fsub.c | 262 ++--- drivers/net/intel/iavf/iavf_generic_flow.c | 107 +- drivers/net/intel/iavf/iavf_generic_flow.h | 2 +- drivers/net/intel/iavf/iavf_hash.c | 153 +-- drivers/net/intel/iavf/iavf_ipsec_crypto.c | 43 +- drivers/net/intel/ice/ice_acl_filter.c | 146 ++- drivers/net/intel/ice/ice_fdir_filter.c | 384 ++++--- drivers/net/intel/ice/ice_generic_flow.c | 59 +- drivers/net/intel/ice/ice_generic_flow.h | 2 +- drivers/net/intel/ice/ice_hash.c | 189 ++-- drivers/net/intel/ice/ice_switch_filter.c | 389 +++---- drivers/net/intel/ixgbe/ixgbe_flow.c | 1161 +++++++------------- lib/eal/include/rte_common.h | 4 + lib/meson.build | 2 + 22 files changed, 2269 insertions(+), 2272 deletions(-) create mode 100644 drivers/net/intel/common/flow_check.h create mode 100644 drivers/net/intel/common/log.h
Signature · 1 line
2.47.3