Skip to content

selftests/bpf: fix flaky build_id test

Gregory Bell bpf 2 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesApplied 2/2
  2. v12 patches 0 repliesSuperseded

changelog from the cover letter

- fixed indentations
- removed trailing whitespace
- add space between opening and closing brackets

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2selftests/bpf: fix flaky build_id testtools/testing/selftests/bpf/uprobe_multi.c+16 -30 repliesApplied
2/2selftests/bpf: align build_id test mapping to 64K page sizetools/testing/selftests/bpf/uprobe_multi.ld+2 -20 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH bpf-next v2 0/2] selftests/bpf: fix flaky build_id test

The build_id selftest intermittently fails with the following error:

./test_progs -t build_id/nofault-paged-out serial_test_build_id:PASS:parse_build_id 0 nsec subtest_nofault:PASS:skel_open 0 nsec
subtest_nofault:PASS:link 0 nsec
subtest_nofault:PASS:trigger_uprobe 0 nsec
subtest_nofault:PASS:res 0 nsec
subtest_nofault:FAIL:build_id_status unexpected build_id_status: actual 1 != expected 2
46/1 build_id/nofault-paged-out:FAIL
46 build_id:FAIL
397 stacktrace_build_id:OK
398 stacktrace_build_id_nmi:OK

On RHEL we consistently hit the reported failure on the first run of the test following installation, after which subsequent runs pass.

This patch implements the approach discussed in the following thread:
https://lore.kernel.org/all/CAEf4BzYWVtfZh07iQm5Fo=kMm+8hgAu+rXRx1uLRHz07wc59+Q@mail.gmail.com/

Following the discussion, the fix makes the test verify eviction rather than assuming it. In the discussion it was recommended to add a sleep before and after the madvise operations, this did not resolve the issue in our case, rather the test timed out every time. I was successful by retrying the page-out sequence until the page is actually evicted.

Additionally, the mapping alignment is increased to
64K so the test operates on a properly page-aligned buffer across supported architectures.

changelog:
- fixed indentations
- removed trailing whitespace
- add space between opening and closing brackets

Gregory Bell (2):
selftests/bpf: fix flaky build_id test selftests/bpf: align build_id test mapping to 64K page size

 tools/testing/selftests/bpf/uprobe_multi.c  | 19 ++++++++++++++++---
 tools/testing/selftests/bpf/uprobe_multi.ld |  4 ++--
 2 files changed, 18 insertions(+), 5 deletions(-)
Signature · 1 line
2.52.0