Bluetooth: hci_ll: Enable BROKEN_ENHANCED_SETUP_SYNC_CONN for WL183x
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest1 patch 7 repliesIn review
Changes in v2 from the cover letter
- Remove DT property, used compatible instead
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | Bluetooth: hci_ll: Enable BROKEN_ENHANCED_SETUP_SYNC_CONN for WL183xdrivers/ | +10 | 7 replies |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | Paul Menzel |
|---|---|
| 1/1 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/1] Bluetooth: hci_ll: Enable BROKEN_ENHANCED_SETUP_SYNC_CONN for WL183x
While validating SCO audio on a platform using TI WL183x Bluetooth modules with the hci_ll driver, we observed failures when the HCI Enhanced Setup Synchronous Connection command was used.
Although the controller advertises support for the command, SCO setup fails in certain configurations (e.g. BT_VOICE_TRANSPARENT/mSBC). This matches the scenario described in commit 05abad857277 ("Bluetooth: HCI: Add HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN quirk").
Initially, we considered setting the HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN quirk unconditionally in hci_ll. However, this would affect all TI controllers handled by the driver, including configurations where the enhanced setup command works correctly.
To avoid hardcoding the quirk globally, we first proposed a DT-based solution. Based on review feedback, the quirk is now enabled automatically for the affected devices by deducing it from the compatible string instead.
The issue has been observed on WL1831, WL1835 and WL1837 modules, therefore the quirk is enabled for:
- "ti,wl1831-st"
- "ti,wl1835-st"
- "ti,wl1837-st"
This keeps the change limited to the affected WL183x family and avoids impacting other TI controllers handled by hci_ll.
v1->v2:
- Remove DT property, used compatible instead
v1:
Stefano Radaelli (1):
Bluetooth: hci_ll: Enable BROKEN_ENHANCED_SETUP_SYNC_CONN for WL183x
drivers/bluetooth/hci_ll.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
Signature · 1 line
2.47.3