Skip to content

Add driver for TI BQ25630 charger

Waqar Hameed linux-devicetree linux-pm lkml sashiko-reviews 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesApplied
  2. v22 patches 5 repliesSuperseded
  3. v1 RFC2 patches 7 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2dt-bindings: power: supply: Add TI BQ25630 chargerDocumentation/devicetree/bindings/power/supply/ti,bq25630.yaml+55 -01 reply
2/2power: supply: Add driver for TI BQ25630 chargerdrivers/power/supply/Kconfig drivers/power/supply/Makefile drivers/power/supply/bq25630_charger.c+1081 -02 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Add driver for TI BQ25630 charger

This patch series contains a fully working driver for the basic functionality for the new TI BQ25630 charger (see datasheet [1]). The other "advanced" functionalities such as USB OTG, BATFET control and liquid detection, will be handled in separate patches (after necessary framework changes) according to the design discussions in the first RFC version.

[1] https://www.ti.com/lit/gpn/bq25630

Changes in v3:

[power]
* Sort variable declarations in reverse x-mas tree order in read/write property functions.

[dt-bindings]
* Drop description for property reg.
* Remove | in description for property interrupts.
* Remove monitored-battery from properties.
* Use unevaluatedProperties: false instead of additionalProperties: false.

Link to v2: https://lore.kernel.org/lkml/[email protected]/

Changes in v2:

[power]
* Fix return value check for data->regmap16be initialization in probe (check was wrongly for data->regmap16le).
* Remove TODO-comment about BATFET sysfs ABI (we will add a new sysfs ABI entry in the framework for this).
* Check registers BQ25630_REG_CHARGER_STATUS_X as well in IRQ handler. Because there might be changes that is not necessarily *only* triggered from hardware faults. For example, manually enabling/disabling with echo 0 > /online.

[dt-bindings]
* Rename file with ti, prefix.
* Remove battery-node in example.

Link to v1: https://lore.kernel.org/lkml/[email protected]/

Waqar Hameed (2):
dt-bindings: power: supply: Add TI BQ25630 charger
power: supply: Add driver for TI BQ25630 charger

 .../bindings/power/supply/ti,bq25630.yaml     |   55 +
 drivers/power/supply/Kconfig                  |    7 +
 drivers/power/supply/Makefile                 |    1 +
 drivers/power/supply/bq25630_charger.c        | 1073 +++++++++++++++++
 4 files changed, 1136 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/ti,bq25630.yaml
 create mode 100644 drivers/power/supply/bq25630_charger.c

base-commit: ab9de95c9cf952332ab79453b4b5d1bfca8e514f

Signature · 1 line
2.43.0