Skip to content

bnxt_en: Add XDP RSS hash metadata support

Chris J Arges bpf linux-kselftest netdev 5 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 0 repliesApplied 6/6
  2. v46 patches 6 repliesSuperseded
  3. v35 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches5 repliesSuperseded
v14 patches3 repliesSuperseded

Patches in v5 All 6 applied

#Subject and filesSizeRepliesApplied
1/6bnxt_en: use bnxt_xdp_buff for xdp contextdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h+26 -100 repliesApplied
2/6bnxt_en: Implement XDP RSS hash metadata extractiondrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c +1 more+57 -00 repliesApplied
3/6bnxt_en: Move bnxt_rss_ext_op into headerdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+17 -170 repliesApplied
4/6bnxt_en: Implement XDP RSS hash metadata extraction for V3_CMPdrivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c+10 -00 repliesApplied
5/6selftests: net: move common xdp.py functions into libtools/testing/selftests/drivers/net/lib/py/__init__.py tools/testing/selftests/drivers/net/xdp.py tools/testing/selftests/net/lib/py/__init__.py +1 more+94 -740 repliesApplied
6/6selftests: drv-net: xdp: Add rss_hash metadata teststools/testing/selftests/drivers/net/hw/Makefile tools/testing/selftests/drivers/net/hw/lib/py/__init__.py tools/testing/selftests/drivers/net/hw/xdp_metadata.py +1 more+312 -00 repliesApplied

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchJoe DamatoAndy Gospodarek
1/6
2/6R-b R-b
3/6R-b
4/6R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH net-next v5 0/6] bnxt_en: Add XDP RSS hash metadata support

This series adds XDP RSS hash metadata extraction support for the bnxt_en driver and includes selftests to validate the functionality. I was able to test this on a BCM57414 NIC.

Patches 1-4 implement the driver support:
- Patch 1 adds bnxt_xdp_buff to wrap xdp_buff with
pointers to the hardware RX completion descriptors and the completion type. This is similar to other driver implementations.
- Patch 2 adds xmo_rx_hash callback for CMP_TYPE_RX_L2_CMP completions.
- Patch 3 moves bnxt_rss_ext_op to bnxt.h
- Patch 4 adds handling for CMP_TYPE_RX_L2_V3_CMP completions

Patches 5-6 add selftest coverage:
- Patch 5 refactors common BPF map helper functions out of the existing xdp.py selftest into a shared net/lib/py/bpf.py module.
- Patch 6 adds an XDP metadata selftest that loads an XDP program calling bpf_xdp_metadata_rx_hash. The test skips on devices without xdp-rx-metadata-features.

Changes from v4: https://lore.kernel.org/all/[email protected]/
- address RCT again
- make _format_hex_bytes private
- remove redundant bpf_map_set
- rebased on net-next

Changes from v3: https://lore.kernel.org/netdev/[email protected]/
- split out bnxt_rss_ext_op into header
- address RCT issue
- rebased on net-next

Changes from v2: https://lore.kernel.org/netdev/[email protected]/
- bnxt xdp: actually fixed RCT issues
- bnxt xdp: Added patch 3 to handle CMP_TYPE_RX_L2_V3_CMP completions.

Changes from v1: https://lore.kernel.org/netdev/[email protected]/
- selftests: moved tests into net/hw
- selftests: fix pylinter errors
- selftests: add check for no error count
- bnxt_xdp: followed RCT for variable declaration
- rebased on net-next

Chris J Arges (6):
bnxt_en: use bnxt_xdp_buff for xdp context
bnxt_en: Implement XDP RSS hash metadata extraction
bnxt_en: Move bnxt_rss_ext_op into header
bnxt_en: Implement XDP RSS hash metadata extraction for V3_CMP
selftests: net: move common xdp.py functions into lib
selftests: drv-net: xdp: Add rss_hash metadata tests

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  51 +++---
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  19 ++
 drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c |  57 ++++++
 drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h |  10 ++
 .../testing/selftests/drivers/net/hw/Makefile |   1 +
 .../drivers/net/hw/lib/py/__init__.py         |   2 +
 .../selftests/drivers/net/hw/xdp_metadata.py  | 146 ++++++++++++++++
 .../selftests/drivers/net/lib/py/__init__.py  |   2 +
 tools/testing/selftests/drivers/net/xdp.py    |  96 +++--------
 .../testing/selftests/net/lib/py/__init__.py  |   2 +
 tools/testing/selftests/net/lib/py/bpf.py     |  68 ++++++++
 .../selftests/net/lib/xdp_metadata.bpf.c      | 163 ++++++++++++++++++
 12 files changed, 516 insertions(+), 101 deletions(-)
 create mode 100644 tools/testing/selftests/drivers/net/hw/xdp_metadata.py
 create mode 100644 tools/testing/selftests/net/lib/py/bpf.py
 create mode 100644 tools/testing/selftests/net/lib/xdp_metadata.bpf.c
Signature · 1 line
2.43.0