Skip to content

repo_config_values: migrate more globals variables

Olamide Caleb Bello git 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest8 patches 0 repliesNew
  2. v48 patches 6 repliesSuperseded
  3. v3 posting 2/28 patches 8 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 posting 1/28 patches1 replySuperseded
v28 patches12 repliesSuperseded
v18 patches5 repliesSuperseded

Changes in v5 from the cover letter

- environment: move "precomposed_unicode" into struct repo_config_values:
remove incorrect mention of changing int to bool

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8environment: move "trust_ctime" into `struct repo_config_values`environment.c environment.h statinfo.c+7 -50 replies
2/8environment: move "check_stat" into `struct repo_config_values`entry.c environment.c environment.h +1 more+11 -100 replies
3/8environment: move `zlib_compression_level` into `struct repo_config_values`builtin/index-pack.c diff.c environment.c +3 more+12 -80 replies
4/8environment: move "pack_compression_level" into `struct repo_config_values`builtin/fast-import.c builtin/pack-objects.c environment.c +2 more+23 -150 replies
5/8environment: move "precomposed_unicode" into `struct repo_config_values`compat/precompose_utf8.c environment.c environment.h +1 more+18 -110 replies
6/8environment: move "core_sparse_checkout_cone" into `struct repo_config_values`builtin/mv.c builtin/sparse-checkout.c dir.c +3 more+29 -210 replies
7/8environment: move "sparse_expect_files_outside_of_patterns" into `struct repo_config_values`environment.c environment.h sparse-index.c+8 -50 replies
8/8environment: move "warn_on_object_refname_ambiguity" into `struct repo_config_values`builtin/cat-file.c builtin/pack-objects.c environment.c +4 more+20 -150 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

PatchChristian CouderUsman Akinyemi
1/8Mentored-by
2/8Mentored-by Mentored-by
3/8Mentored-by Mentored-by
4/8Mentored-by Mentored-by
5/8Mentored-by Mentored-by
6/8Mentored-by Mentored-by
7/8Mentored-by Mentored-by
8/8Mentored-by Mentored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/8] repo_config_values: migrate more globals variables

Changes since v4:

- environment: move "precomposed_unicode" into struct repo_config_values:
remove incorrect mention of changing int to bool

Olamide Caleb Bello (8):
environment: move "trust_ctime" into struct repo_config_values
environment: move "check_stat" into struct repo_config_values
environment: move zlib_compression_level into `struct
repo_config_values`
environment: move "pack_compression_level" into `struct
repo_config_values`
environment: move "precomposed_unicode" into `struct
repo_config_values`
environment: move "core_sparse_checkout_cone" into `struct
repo_config_values`
environment: move "sparse_expect_files_outside_of_patterns" into
struct repo_config_values
environment: move "warn_on_object_refname_ambiguity" into `struct
repo_config_values`

 builtin/cat-file.c        |  7 ++++---
 builtin/fast-import.c     |  8 +++++---
 builtin/index-pack.c      |  3 ++-
 builtin/mv.c              |  2 +-
 builtin/pack-objects.c    | 24 +++++++++++++----------
 builtin/sparse-checkout.c | 37 +++++++++++++++++++++---------------
 compat/precompose_utf8.c  | 20 +++++++++++++-------
 diff.c                    |  3 ++-
 dir.c                     |  3 ++-
 entry.c                   |  3 ++-
 environment.c             | 40 +++++++++++++++++++++------------------
 environment.h             | 19 ++++++++++---------
 http-push.c               |  3 ++-
 object-file.c             |  6 ++++--
 object-name.c             |  3 ++-
 revision.c                |  7 ++++---
 sparse-index.c            |  4 ++--
 statinfo.c                | 12 +++++++-----
 submodule.c               |  7 ++++---
 upload-pack.c             |  3 ++-
 20 files changed, 126 insertions(+), 88 deletions(-)
Signature · 1 line
2.53.0.155.g9f36b15afa