Skip to content

change young flag check functions to return bool

Baolin Wang kvm linux-arm-kernel linux-mm linux-parisc linux-riscv linux-s390 linuxppc-dev lkml 2 versions – Applied

Status from this message: This series was applied to riscv/linux.git (fixes)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyApplied 6/6
  2. v16 patches 23 repliesSuperseded

Changes in v2 from the cover letter

- Add reviewed tag from Lorenzo and Ritesh. Thanks.
- Drop extern and use 2 tabs indentation, per Lorenzo.
- Fix the incorrect conversion of the 'id' variable.

Patches in v2 All 6 applied

#Subject and filesSizeRepliesApplied
1/6mm: change to return bool for ptep_test_and_clear_young()arch/arm64/include/asm/pgtable.h arch/arm64/mm/contpte.c arch/microblaze/include/asm/pgtable.h +11 more+46 -500 repliesApplied
2/6mm: change to return bool for ptep_clear_flush_young()/clear_flush_young_ptes()arch/arm64/include/asm/pgtable.h arch/arm64/mm/contpte.c arch/parisc/include/asm/pgtable.h +8 more+33 -340 repliesApplied
3/6mm: change to return bool for pmdp_test_and_clear_young()arch/arm64/include/asm/pgtable.h arch/powerpc/include/asm/book3s/64/pgtable.h arch/powerpc/mm/book3s64/pgtable.c +5 more+27 -290 repliesApplied
4/6mm: change to return bool for pmdp_clear_flush_young()arch/s390/include/asm/pgtable.h arch/x86/include/asm/pgtable.h arch/x86/mm/pgtable.c +2 more+16 -150 repliesApplied
5/6mm: change to return bool for pudp_test_and_clear_young()arch/powerpc/include/asm/book3s/64/pgtable.h arch/powerpc/mm/book3s64/pgtable.c arch/riscv/include/asm/pgtable.h +2 more+14 -140 repliesApplied
6/6mm: change to return bool for the MMU notifier's young flag checkinclude/linux/mmu_notifier.h mm/internal.h mm/mmu_notifier.c +1 more+66 -800 repliesApplied

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRitesh Harjani (IBM)Lorenzo Stoakes (Oracle)David Hildenbrand (Arm)
SeriesA-b
1/6R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b
5/6R-b R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/6] change young flag check functions to return bool

This is a cleanup patchset to change all young flag check functions to return bool, as discussed with David in the previous thread[1]. Since callers only care about whether the young flag was set, returning bool makes the intention clearer. No functional changes intended.

Ran mm selftests on Arm64 and x86 machines, and no issues were found.

Note that I only CC'd the arch mailing lists to avoid disturbing too many people.

[1] https://lore.kernel.org/all/[email protected]/

Changes from v1:
- Add reviewed tag from Lorenzo and Ritesh. Thanks.
- Drop extern and use 2 tabs indentation, per Lorenzo.
- Fix the incorrect conversion of the 'id' variable.

Baolin Wang (6):
mm: change to return bool for ptep_test_and_clear_young()
mm: change to return bool for
ptep_clear_flush_young()/clear_flush_young_ptes()
mm: change to return bool for pmdp_test_and_clear_young()
mm: change to return bool for pmdp_clear_flush_young()
mm: change to return bool for pudp_test_and_clear_young()
mm: change to return bool for the MMU notifier's young flag check

 arch/arm64/include/asm/pgtable.h             | 38 +++++-----
 arch/arm64/mm/contpte.c                      | 14 ++--
 arch/microblaze/include/asm/pgtable.h        |  2 +-
 arch/parisc/include/asm/pgtable.h            |  9 +--
 arch/parisc/kernel/cache.c                   |  8 +--
 arch/powerpc/include/asm/book3s/32/pgtable.h |  4 +-
 arch/powerpc/include/asm/book3s/64/pgtable.h | 26 +++----
 arch/powerpc/include/asm/nohash/64/pgtable.h |  2 +-
 arch/powerpc/include/asm/nohash/pgtable.h    |  4 +-
 arch/powerpc/mm/book3s64/pgtable.c           |  8 +--
 arch/riscv/include/asm/pgtable.h             | 16 ++---
 arch/riscv/mm/pgtable.c                      |  7 +-
 arch/s390/include/asm/pgtable.h              | 16 ++---
 arch/x86/include/asm/pgtable.h               | 20 +++---
 arch/x86/mm/pgtable.c                        | 28 ++++----
 arch/xtensa/include/asm/pgtable.h            |  9 ++-
 include/linux/mmu_notifier.h                 | 76 +++++++++-----------
 include/linux/pgtable.h                      | 53 +++++++-------
 mm/internal.h                                | 16 ++---
 mm/mmu_notifier.c                            | 23 +++---
 mm/pgtable-generic.c                         | 14 ++--
 virt/kvm/kvm_main.c                          | 31 +++-----
 22 files changed, 202 insertions(+), 222 deletions(-)
Signature · 1 line
2.47.3