Skip to content

preserve promisor files content after repack

LorenzoPegorari git 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 2 repliesIn review
  2. v56 patches 8 repliesSuperseded
  3. v45 patches 7 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches14 repliesSuperseded
v24 patches8 repliesSuperseded
v13 patches2 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6pack-write: add explanation to promisor file contentpack-write.c+9 -00 replies
2/6repack-promisor add helper to fill promisor file after repackrepack-promisor.c+149 -00 replies
3/6repack-promisor: preserve content of promisor files after repackDocumentation/git-repack.adoc repack-promisor.c+22 -210 replies
4/6t7700: test for promisor file content after repackt/t7700-repack.sh+61 -00 replies
5/6t7703: test for promisor file content after geometric repackt/t7703-repack-geometric.sh+33 -00 replies
6/6repack-promisor: add missing headersrepack-promisor.c+6 -00 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchJunio C HamanoEric SunshineTian Yuchen
1/6Helped-by
2/6Helped-by Helped-by Helped-by
3/6Helped-by Helped-by
4/6Helped-by Helped-by
5/6Helped-by
6/6Helped-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [GSoC PATCH v6 0/6] preserve promisor files content after repack

The goal of this patch is to solve the NEEDSWORK comment added by 5374a290 (fetch-pack: write fetched refs to .promisor, 14/10/2019). This is done by adding a helper function that takes the content of all .promisor files in the repository, and copies it inside the first .promisor file created by the repack.

Also, I added a comment explaining what is the purpose of the content of the .promisor files, since this wasn't explained anywhere (I found information regarding this only in the message of the previously cited commit).

Finally, I added some tests to "t7700-repack.sh" and "t7703-repack-geometric.sh" that check if the content of .promisor files are correctly copied into the .promisor files created by a repack.

V6 DIFF:
* changed the name of the helper function to write_promisor_file_after_repack.
* modified the helper function to create the ".promisor" file, so that is not required anymore.
* modified the logic of the helper function (as suggested by Tian Yuchen)
* modified the helper function to check for possible errors, and to check if the lines of the ".promisor" files are correctly formed.
* fixed memory leak.
* improved comments.

LorenzoPegorari (6):
pack-write: add explanation to promisor file content repack-promisor add helper to fill promisor file after repack
repack-promisor: preserve content of promisor files after repack
t7700: test for promisor file content after repack
t7703: test for promisor file content after geometric repack
repack-promisor: add missing headers

 Documentation/git-repack.adoc |   4 +-
 pack-write.c                  |   9 ++
 repack-promisor.c             | 194 ++++++++++++++++++++++++++++++----
 t/t7700-repack.sh             |  61 +++++++++++
 t/t7703-repack-geometric.sh   |  33 ++++++
 5 files changed, 280 insertions(+), 21 deletions(-)
Signature · 1 line
2.53.0.584.g6b87e8e9dd