preserve promisor files content after repack
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest6 patches 2 repliesIn review
- v56 patches 8 repliesSuperseded
- v45 patches 7 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 5 patches | 14 replies | Superseded | |
| v2 | 4 patches | 8 replies | Superseded | |
| v1 | 3 patches | 2 replies | Superseded |
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | pack-write: add explanation to promisor file contentpack-write.c | +9 | 0 replies | |
| 2/6 | repack-promisor add helper to fill promisor file after repackrepack-promisor.c | +149 | 0 replies | |
| 3/6 | repack-promisor: preserve content of promisor files after repackDocumentation/ repack-promisor.c | +22 | 0 replies | |
| 4/6 | t7700: test for promisor file content after repackt/ | +61 | 0 replies | |
| 5/6 | t7703: test for promisor file content after geometric repackt/ | +33 | 0 replies | |
| 6/6 | repack-promisor: add missing headersrepack-promisor.c | +6 | 0 replies |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by.
| Patch | Junio C Hamano | Eric Sunshine | Tian Yuchen |
|---|---|---|---|
| 1/6 | Helped-by | ||
| 2/6 | Helped-by | Helped-by | Helped-by |
| 3/6 | Helped-by | Helped-by | |
| 4/6 | Helped-by | Helped-by | |
| 5/6 | Helped-by | ||
| 6/6 | Helped-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [GSoC PATCH v6 0/6] preserve promisor files content after repack
The goal of this patch is to solve the NEEDSWORK comment added by 5374a290 (fetch-pack: write fetched refs to .promisor, 14/10/2019). This is done by adding a helper function that takes the content of all .promisor files in the repository, and copies it inside the first .promisor file created by the repack.
Also, I added a comment explaining what is the purpose of the content of the .promisor files, since this wasn't explained anywhere (I found information regarding this only in the message of the previously cited commit).
Finally, I added some tests to "t7700-repack.sh" and "t7703-repack-geometric.sh" that check if the content of .promisor files are correctly copied into the .promisor files created by a repack.
V6 DIFF:
* changed the name of the helper function to write_promisor_file_after_repack.
* modified the helper function to create the ".promisor" file, so that is not required anymore.
* modified the logic of the helper function (as suggested by Tian Yuchen)
* modified the helper function to check for possible errors, and to check if the lines of the ".promisor" files are correctly formed.
* fixed memory leak.
* improved comments.
LorenzoPegorari (6):
pack-write: add explanation to promisor file content repack-promisor add helper to fill promisor file after repack
repack-promisor: preserve content of promisor files after repack
t7700: test for promisor file content after repack
t7703: test for promisor file content after geometric repack
repack-promisor: add missing headers
Documentation/git-repack.adoc | 4 +- pack-write.c | 9 ++ repack-promisor.c | 194 ++++++++++++++++++++++++++++++---- t/t7700-repack.sh | 61 +++++++++++ t/t7703-repack-geometric.sh | 33 ++++++ 5 files changed, 280 insertions(+), 21 deletions(-)
Signature · 1 line
2.53.0.584.g6b87e8e9dd