btrfs: DEV_STATS item related minor fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | btrfs: remove the dev stats item for replace target devicefs/ fs/ fs/ | +41 | 0 replies | |
| 2/4 | btrfs: remove the dev stats item when removing a devicefs/ | +6 | 0 replies | |
| 3/4 | btrfs: always update/create the dev stats item when adding a new devicefs/ fs/ | +8 | 0 replies | |
| 4/4 | btrfs: avoid unnecessary dev stats updatesfs/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] btrfs: DEV_STATS item related minor fixes
[BACKGROUND]DEV_STATS (objectid, not type) items are storing the error counts for each device. It's updated every time an error is hit, including the following types:
- READ errors
- WRITE errors
- FLUSH errors
Above alls are all errors directly returned from the device.
- CORRUPTION errors
Aka, checksum mismatch.
- GENERATION errors
Metadata generation mismatch.
[MINOR BUGS]
Recently when debugging an error reported about rejected dev-replace, the device tree dump includes a DEV_STATS item for devid 0.
I'm wondering if that DEV_STATS item will ever be deleted, but unfortunately it will never be deleted.
Normally it's not a big deal, as the DEV_STATS are normally all zeros.
But if it's not, and a new dev-replace is started and interrupted, at the next mount the replace target device will suddenly inherit all the error records, giving end users false alerts about a completely good device.
[FIX]
The first 2 are manually removing the DEV_STATS items when dev-replace and dev-removal finishes.
The 3rd patch is a more generic fix by forcing btrfs to update/create DEV_STATS item after a new device is added.
This means for patched kernels, even there is some old DEV_STATS left, the kernel will never re-use them during device add or dev-replace.
The last one is to reduce unnecessary DEV_STATS updates.
Qu Wenruo (4):
btrfs: remove the dev stats item for replace target device
btrfs: remove the dev stats item when removing a device
btrfs: always update/create the dev stats item when adding a new
device
btrfs: avoid unnecessary dev stats updates
fs/btrfs/dev-replace.c | 11 +++++++++- fs/btrfs/volumes.c | 48 ++++++++++++++++++++++++++++++++++++++++-- fs/btrfs/volumes.h | 1 + 3 files changed, 57 insertions(+), 3 deletions(-)
Signature · 1 line
2.53.0