Skip to content

RFC pseries/papr-hvpipe: Fix and simplify papr-hvpipe

Ritesh Harjani (IBM) linuxppc-dev lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6pseries/papr-hvpipe: Fix null ptr deref in papr_hvpipe_dev_create_handlearch/powerpc/platforms/pseries/papr-hvpipe.c+22 -281 reply
2/6pseries/papr-hvpipe: Fix the usage of copy_to_user()arch/powerpc/platforms/pseries/papr-hvpipe.c+5 -40 replies
3/6pseries/papr-hvpipe: Simplify spin_unlock() usage in papr_hvpipe_handle_releasearch/powerpc/platforms/pseries/papr-hvpipe.c+2 -30 replies
4/6pseries/papr-hvpipe: Kill task_struct pointer from struct hvpipe_source_infoarch/powerpc/platforms/pseries/papr-hvpipe.c arch/powerpc/platforms/pseries/papr-hvpipe.h+2 -40 replies
5/6pseries/papr-hvpipe: Refactor and simplify hvpipe_rtas_recv_msg()arch/powerpc/platforms/pseries/papr-hvpipe.c+26 -260 replies
6/6pseries/papr-hvpipe: Simplify error handling in papr_hvpipe_init()arch/powerpc/platforms/pseries/papr-hvpipe.c+15 -110 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchChristian Brauner
1/6R-b
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC v1 0/6] pseries/papr-hvpipe: Fix and simplify papr-hvpipe

Haren reported a UAF / null ptr deref issue here [1]. While reviewing that and going over papr-hvpipe code, I found couple of more issues around the usage of copy_to_user() and few refactoring which simplifies the code.

This patch series is an attempt to that. Note that this is only compile tested on pseries for now.

Haren, I will kindly need your help in verifying this please. Let me know if we have a selftests or any other test framework for this, which I can utilize too.

[1]: https://lore.kernel.org/linuxppc-dev/[email protected]/

Ritesh Harjani (IBM) (6):
pseries/papr-hvpipe: Fix null ptr deref in papr_hvpipe_dev_create_handle pseries/papr-hvpipe: Fix the usage of copy_to_user() pseries/papr-hvpipe: Simplify spin_unlock() usage in papr_hvpipe_handle_release pseries/papr-hvpipe: Kill task_struct pointer from struct hvpipe_source_info pseries/papr-hvpipe: Refactor and simplify hvpipe_rtas_recv_msg() pseries/papr-hvpipe: Simplify error handling in papr_hvpipe_init()

 arch/powerpc/platforms/pseries/papr-hvpipe.c | 135 +++++++++----------
 arch/powerpc/platforms/pseries/papr-hvpipe.h |   1 -
 2 files changed, 66 insertions(+), 70 deletions(-)

--
2.39.5