uaccess/sockptr: copy_struct_ fixes and more helpers
Status from this message: Applied to the vfs-7.2.misc branch of the vfs/vfs.git tree.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | uaccess: fix ignored_trailing logic in copy_struct_to_user()include/ | +1 | 4 replies | |
| 2/5 | sockptr: fix usize check in copy_struct_from_sockptr() for user pointersinclude/ | +1 | 2 replies | |
| 3/5 | uaccess: add copy_struct_{from,to}_bounce_buffer() helpersinclude/ | +63 | 2 replies | |
| 4/5 | sockptr: let copy_struct_from_sockptr() use copy_struct_from_bounce_buffer()include/ | +1 | 0 replies | |
| 5/5 | sockptr: introduce copy_struct_to_sockptr()include/ | +10 | 0 replies |
Reviews trailers per patch
2 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Aleksa Sarai |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] uaccess/sockptr: copy_struct_ fixes and more helpers
Hi,
here are some patches related to copy_struct_{from,to}_{user,sockptr}()
I collected during my work on an IPPROTO_SMBDIRECT implementation wrapping the smbdirect code used by cifs.ko and ksmbd.ko.
The first patch fixes copy_struct_to_user() to behave like documented.
The 2nd patch fixes the case wherecopy_struct_from_user() is called bycopy_struct_from_sockptr().
The 3rd patch introduces copy_struct_{from,to}_bounce_buffer()
as a result of a discussion about the IPPROTO_QUIC driver in order to
be future prove when handling msg_control messages in sendmsg and recvmsg.
But I'll likely also use them in my IPPROTO_SMBDIRECT driver.
The 4th patch makes copy_struct_from_sockptr() a trivial wrapper switching between copy_struct_from_user() and copy_struct_from_bounce_buffer()
The 5th patch introduces copy_struct_to_sockptr() which I'll also use in my IPPROTO_SMBDIRECT driver.
As future cleanup I was thinking about trick to hide size_t ksize from the callers, similar to what was done with kmalloc_obj(). Whould others think that would be useful?
Stefan Metzmacher (5):
uaccess: fix ignored_trailing logic in copy_struct_to_user()
sockptr: fix usize check in copy_struct_from_sockptr() for user
pointers
uaccess: add copy_struct_{from,to}_bounce_buffer() helpers
sockptr: let copy_struct_from_sockptr() use
copy_struct_from_bounce_buffer()
sockptr: introduce copy_struct_to_sockptr()
include/linux/sockptr.h | 28 ++++++++---------- include/linux/uaccess.h | 65 ++++++++++++++++++++++++++++++++++++++++- 2 files changed, 76 insertions(+), 17 deletions(-)
Signature · 1 line
2.43.0