Skip to content

Add support for ubi environment to create volumes (v5)

Weijie Gao u-boot 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 patches 0 repliesNew
  2. v410 patches 9 repliesSuperseded
  3. v310 patches 9 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v28 patches8 repliesSuperseded
v13 patches8 repliesSuperseded

Changes from the cover letter

v5: Return CMD_RET_USAGE on all usage error path
Return -ENODEV instead of PTR_ERR(mtd) in ubi_part() Fix commit message mistake
Fix API function description comments
Fix Kconfig help text

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ubi: remove unnecessary extern directive from function prototypesinclude/ubi_uboot.h+6 -60 replies
2/10cmd: ubi: mark read-only function parameters with constcmd/ubi.c include/ubi_uboot.h+26 -220 replies
3/10cmd: ubi: use void * for buf parameter in ubi_volume_readcmd/ubi.c env/ubi.c include/ubi_uboot.h+5 -50 replies
4/10cmd: ubifs: mark string parameters with constcmd/ubifs.c fs/ubifs/super.c fs/ubifs/ubifs.c +2 more+6 -60 replies
5/10cmd: ubi: change the type of parameter dynamic to boolcmd/ubi.c+3 -30 replies
6/10cmd: ubi: change all positive error return value to negativecmd/ubi.c+48 -440 replies
7/10cmd: ubi: reorganize command messagescmd/ubi.c+95 -430 replies
8/10cmd: ubi: export more APIs to publiccmd/ubi.c include/ubi_uboot.h+108 -60 replies
9/10cmd: ubi: allow creating volume with all free spaces in ubi_create_volcmd/ubi.c+5 -10 replies
10/10env: ubi: add support to create environment volume if it does not existenv/Kconfig env/ubi.c+74 -110 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchSimon Glass
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/10] Add support for ubi environment to create volumes (v5)

This patch series expose more ubi helpers to allow the ubi environment to create ubi env volumes before loading if they're not exist.

Changes:
v5: Return CMD_RET_USAGE on all usage error path
Return -ENODEV instead of PTR_ERR(mtd) in ubi_part() Fix commit message mistake
Fix API function description comments
Fix Kconfig help text

v4: Adjust command message. Error messages will be printed in both command
and api call.
Add parameter check for "ubi rename" subcommand
Fix duplicated call to ubi_require_volume() in command. Squash api function comments.
Change all return value to negative.
Add another kconfig option to control whether to create static volume. Read environment volume only when it exists or has been created.

v3: Fix command messages
Fix some incorrect code flow and error handling Correct dynamic parameter type
Add comments for exported functions

v2: Add const qualifier for char */void * in function parameters
Adjust normal command message

Weijie Gao (10):
ubi: remove unnecessary extern directive from function prototypes
cmd: ubi: mark read-only function parameters with const
cmd: ubi: use void * for buf parameter in ubi_volume_read
cmd: ubifs: mark string parameters with const
cmd: ubi: change the type of parameter dynamic to bool
cmd: ubi: change all positive error return value to negative
cmd: ubi: reorganize command messages
cmd: ubi: export more APIs to public
cmd: ubi: allow creating volume with all free spaces in ubi_create_vol
env: ubi: add support to create environment volume if it does not
exist

 cmd/ubi.c             | 272 +++++++++++++++++++++++++++---------------
 cmd/ubifs.c           |   2 +-
 env/Kconfig           |  20 ++++
 env/ubi.c             |  65 ++++++++--
 fs/ubifs/super.c      |   2 +-
 fs/ubifs/ubifs.c      |   2 +-
 include/ubi_uboot.h   | 106 ++++++++++++++--
 include/ubifs_uboot.h |   4 +-
 8 files changed, 351 insertions(+), 122 deletions(-)
Signature · 1 line
2.45.2