Skip to content

only remove entry from local_addr_list when sending a REMOVE_ADDR

Geliang Tang mptcp 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 4 repliesIn review
  2. v53 patches 3 repliesSuperseded
  3. v43 patches 2 repliesSuperseded

Changes in v6 from the cover letter

- patch 2: now explicitly removes userspace pm addresses using userspace_pm_rm_addr, instead of merely updating dump_addr expectations.
- patch 3: dropped duplicate "sleep 0.5".
- The pre-existing issue Sashiko mentioned in v5, "it's not safe to decrement sk->sk_omem_alloc synchronously while deferring the actual memory free via kfree_rcu_mightsleep(match)", will be addressed in a separate patch.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mptcp: pm: userspace: drop delete_local_addr helpernet/mptcp/pm_userspace.c+2 -333 replies
2/3selftests: mptcp: join: explicitly remove userspace pm addressestools/testing/selftests/net/mptcp/mptcp_join.sh+3 -10 replies
3/3selftests: mptcp: userspace: send RM_ADDR between server and clienttools/testing/selftests/net/mptcp/userspace_pm.sh+14 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMatthieu Baerts (NGI0)
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH mptcp-next v6 0/3] only remove entry from local_addr_list when sending a REMOVE_ADDR

From: Geliang Tang <[email protected]>

v6:
- patch 2: now explicitly removes userspace pm addresses using userspace_pm_rm_addr, instead of merely updating dump_addr expectations.
- patch 3: dropped duplicate "sleep 0.5".
- The pre-existing issue Sashiko mentioned in v5, "it's not safe to decrement sk->sk_omem_alloc synchronously while deferring the actual memory free via kfree_rcu_mightsleep(match)", will be addressed in a separate patch.

v5:
- rebased.
- add Matt's reviewed tags.
- add a RM_ADDR from the server to the client as Sashiko suggested.
- mptcpd tests (make check) are still OK after this modification.
- Link: https://patchwork.kernel.org/project/mptcp/cover/[email protected]/

v4:
- rebased.
- Link: https://patchwork.kernel.org/project/mptcp/cover/[email protected]/

v3:
- update userspace selftests.
- Link: https://patchwork.kernel.org/project/mptcp/cover/[email protected]/

v2:
- squash patch 1 into patch 2 as Mat suggested.

Geliang Tang (3):
mptcp: pm: userspace: drop delete_local_addr helper
selftests: mptcp: join: explicitly remove userspace pm addresses
selftests: mptcp: userspace: send RM_ADDR between server and client

 net/mptcp/pm_userspace.c                      | 35 ++-----------------
 .../testing/selftests/net/mptcp/mptcp_join.sh |  4 ++-
 .../selftests/net/mptcp/userspace_pm.sh       | 14 ++++++++
 3 files changed, 19 insertions(+), 34 deletions(-)
Signature · 1 line
2.53.0