Skip to content

Fix dma_resv_wait_timeout() return handling in rocket/panfrost ioctls

Gyeyoung Baek dri-devel lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2accel/rocket: Fix prep_bo ioctl leaking positive return from dma_resv_wait_timeout()drivers/accel/rocket/rocket_gem.c+2 -01 reply
2/2drm/panfrost: Fix wait_bo ioctl leaking positive return from dma_resv_wait_timeout()drivers/gpu/drm/panfrost/panfrost_drv.c+2 -03 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBoris BrezillonSteven PriceTomeu VizosoAdrián Larumbe
1/2R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH v1 0/2] Fix dma_resv_wait_timeout() return handling in rocket/panfrost ioctls

dma_resv_wait_timeout() returns a positive 'long' (remaining jiffies) on success, which is truncated to 'int`.
So userspace interpret that as an error.

Each patch explicitly sets ret to 0 on the
success path.

Gyeyoung Baek (2):
accel/rocket: Fix prep_bo ioctl leaking positive return from
dma_resv_wait_timeout()
drm/panfrost: Fix wait_bo ioctl leaking positive return from
dma_resv_wait_timeout()

 drivers/accel/rocket/rocket_gem.c       | 2 ++
 drivers/gpu/drm/panfrost/panfrost_drv.c | 2 ++
 2 files changed, 4 insertions(+)
Signature · 1 line
2.43.0