Skip to content

IXGBE fixes and cleanups

Anatoly Burakov dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15net/ixgbe: fix flows not being scoped to portdrivers/net/intel/ixgbe/ixgbe_ethdev.c drivers/net/intel/ixgbe/ixgbe_ethdev.h drivers/net/intel/ixgbe/ixgbe_flow.c+126 -1460 replies
2/15net/ixgbe: fix shared PF pointer in representordrivers/net/intel/ixgbe/ixgbe_ethdev.c drivers/net/intel/ixgbe/ixgbe_ethdev.h drivers/net/intel/ixgbe/ixgbe_vf_representor.c+50 -170 replies
3/15net/ixgbe: fix non-shared data in IPsec sessiondrivers/net/intel/ixgbe/ixgbe_ipsec.c drivers/net/intel/ixgbe/ixgbe_ipsec.h+7 -61 reply
4/15net/ixgbe: fix SCTP protocol-only flow parsingdrivers/net/intel/ixgbe/ixgbe_flow.c+42 -440 replies
5/15net/ixgbe: fix L4 protocol mask handlingdrivers/net/intel/ixgbe/ixgbe_ethdev.h drivers/net/intel/ixgbe/ixgbe_fdir.c drivers/net/intel/ixgbe/ixgbe_flow.c+15 -870 replies
6/15net/ixgbe: reset flow state on clear pathsdrivers/net/intel/ixgbe/ixgbe_fdir.c drivers/net/intel/ixgbe/ixgbe_flow.c+13 -10 replies
7/15net/ixgbe: store max VFs in adapterdrivers/net/intel/ixgbe/ixgbe_ethdev.c drivers/net/intel/ixgbe/ixgbe_ethdev.h drivers/net/intel/ixgbe/ixgbe_flow.c+7 -50 replies
8/15net/ixgbe: do not use flow list to count flowsdrivers/net/intel/ixgbe/ixgbe_ethdev.c drivers/net/intel/ixgbe/ixgbe_ethdev.h drivers/net/intel/ixgbe/ixgbe_fdir.c +1 more+9 -41 reply
9/15net/ixgbe: remove redundant flow tracking listsdrivers/net/intel/ixgbe/ixgbe_ethdev.h drivers/net/intel/ixgbe/ixgbe_flow.c+21 -900 replies
10/15net/ixgbe: reduce FDIR conf macro usagedrivers/net/intel/ixgbe/ixgbe_ethdev.c drivers/net/intel/ixgbe/ixgbe_fdir.c+23 -140 replies
11/15net/ixgbe: use adapter in flow-related callsdrivers/net/intel/ixgbe/ixgbe_ethdev.c drivers/net/intel/ixgbe/ixgbe_ethdev.h drivers/net/intel/ixgbe/ixgbe_fdir.c +2 more+131 -1060 replies
12/15net/ixgbe: support protocol-only TCP and UDP rulesdrivers/net/intel/ixgbe/ixgbe_flow.c+67 -630 replies
13/15net/ixgbe: write drop queue at initdrivers/net/intel/ixgbe/ixgbe_ethdev.c+3 -00 replies
14/15net/ixgbe: rely less on global flow statedrivers/net/intel/ixgbe/ixgbe_ethdev.c drivers/net/intel/ixgbe/ixgbe_ethdev.h drivers/net/intel/ixgbe/ixgbe_fdir.c +1 more+79 -740 replies
15/15net/ixgbe: refactor flow creationdrivers/net/intel/ixgbe/ixgbe_flow.c+144 -990 replies

Reviews trailers per patch

1 of 15 patches has a Reviewed-by or Acked-by.

PatchBruce RichardsonRadu Nicolau
SeriesSeries-Acked-by
1/15
2/15
3/15A-b
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 00/15] IXGBE fixes and cleanups

This patchset fixes a bunch of very old issues in flow management in IXGBE driver, such as:

- storing process-local pointers in shared memory
- incorrect L4 protocol matching for FDIR
- wrong handling of SCTP flow items
- reading stale FDIR state after flow destroy/flush
- storing all flows in global lists

In addition, some cleanup is also performed - refactors, moving things around to avoid accessing process-local state, and writing read-only values at init instead of deep in FDIR.

Finally, FDIR was also rejecting protocol-only matches for TCP and UDP, these are now supported.

Depends on flow dump patchset: https://patches.dpdk.org/project/dpdk/list/?series=38016

Anatoly Burakov (15):
net/ixgbe: fix flows not being scoped to port net/ixgbe: fix shared PF pointer in representor net/ixgbe: fix non-shared data in IPsec session net/ixgbe: fix SCTP protocol-only flow parsing net/ixgbe: fix L4 protocol mask handling net/ixgbe: reset flow state on clear paths net/ixgbe: store max VFs in adapter net/ixgbe: do not use flow list to count flows net/ixgbe: remove redundant flow tracking lists net/ixgbe: reduce FDIR conf macro usage net/ixgbe: use adapter in flow-related calls net/ixgbe: support protocol-only TCP and UDP rules net/ixgbe: write drop queue at init net/ixgbe: rely less on global flow state net/ixgbe: refactor flow creation

 drivers/net/intel/ixgbe/ixgbe_ethdev.c        | 112 +--
 drivers/net/intel/ixgbe/ixgbe_ethdev.h        |  45 +-
 drivers/net/intel/ixgbe/ixgbe_fdir.c          | 240 +++---
 drivers/net/intel/ixgbe/ixgbe_flow.c          | 716 +++++++++---------
 drivers/net/intel/ixgbe/ixgbe_ipsec.c         |  10 +-
 drivers/net/intel/ixgbe/ixgbe_ipsec.h         |   3 +-
 drivers/net/intel/ixgbe/ixgbe_rxtx.c          |  10 +-
 .../net/intel/ixgbe/ixgbe_vf_representor.c    |  63 +-
 8 files changed, 590 insertions(+), 609 deletions(-)
Signature · 1 line
2.47.3