Skip to content

pinctrl: Fix types in .pin_config_group_get() callbacks

Geert Uytterhoeven linux-arm-kernel linux-gpio linux-mediatek linux-mips linux-omap linux-renesas-soc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7pinctrl: airoha: Fix type in .pin_config_group_get() callbackdrivers/pinctrl/mediatek/pinctrl-airoha.c+1 -10 replies
2/7pinctrl: equilibrium: Fix type in .pin_config_group_get() callbackdrivers/pinctrl/pinctrl-equilibrium.c+2 -10 replies
3/7pinctrl: ingenic: Fix type in .pin_config_group_get() callbackdrivers/pinctrl/pinctrl-ingenic.c+2 -12 replies
4/7pinctrl: mediatek: moore: Fix type in .pin_config_group_get() callbackdrivers/pinctrl/mediatek/pinctrl-moore.c+2 -10 replies
5/7pinctrl: renesas: rzg2l: Fix type in .pin_config_group_get() callbackdrivers/pinctrl/renesas/pinctrl-rzg2l.c+2 -11 reply
6/7pinctrl: renesas: rzv2m: Fix type in .pin_config_group_get() callbackdrivers/pinctrl/renesas/pinctrl-rzv2m.c+2 -10 replies
7/7pinctrl: single: Fix type in .pin_config_group_get() callbackdrivers/pinctrl/pinctrl-single.c+2 -10 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by.

PatchPaul CercueilLad Prabhakar
1/7
2/7
3/7A-b
4/7
5/7R-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] pinctrl: Fix types in .pin_config_group_get() callbacks

Hi all,

On 64-bit platforms, "unsigned long" is 64-bit. However, when checking if all "unsigned long" configuration values passed to the .pin_config_group_get() callback are equal, several drivers use a 32-bit temporary. Fortunately this works, as currently all configuration values fit in 32-bit.

This series makes the code cleaner and more future-proof by changing the types of all temporaries to unsigned long.

I intend to queue patches 5 and 6 in renesas-pinctrl for v7.2. Thanks for your comments!

Geert Uytterhoeven (7):
pinctrl: airoha: Fix type in .pin_config_group_get() callback
pinctrl: equilibrium: Fix type in .pin_config_group_get() callback
pinctrl: ingenic: Fix type in .pin_config_group_get() callback
pinctrl: mediatek: moore: Fix type in .pin_config_group_get() callback
pinctrl: renesas: rzg2l: Fix type in .pin_config_group_get() callback
pinctrl: renesas: rzv2m: Fix type in .pin_config_group_get() callback
pinctrl: single: Fix type in .pin_config_group_get() callback

 drivers/pinctrl/mediatek/pinctrl-airoha.c | 2 +-
 drivers/pinctrl/mediatek/pinctrl-moore.c  | 3 ++-
 drivers/pinctrl/pinctrl-equilibrium.c     | 3 ++-
 drivers/pinctrl/pinctrl-ingenic.c         | 3 ++-
 drivers/pinctrl/pinctrl-single.c          | 3 ++-
 drivers/pinctrl/renesas/pinctrl-rzg2l.c   | 3 ++-
 drivers/pinctrl/renesas/pinctrl-rzv2m.c   | 3 ++-
 7 files changed, 13 insertions(+), 7 deletions(-)
Signature · 12 lines
2.43.0

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds