alloc_tag: introduce IOCTL-based filtering for MAP
Status from this message: [merged mm-stable] kselftest-alloc_tag-extend-the-allocinfo-ioctl-kselftest.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest6 patches 3 repliesApplied 6/6
- v76 patches 3 repliesSuperseded
- v66 patches 4 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 6 patches | 17 replies | Superseded | |
| v4 | 6 patches | 8 replies | Superseded | |
| v3 | 6 patches | 22 replies | Superseded | |
| v2 | 6 patches | 14 replies | Superseded | |
| v1 | 6 patches | 14 replies | Superseded |
Changes in v8 from the cover letter
- Patch 6/6: Changed KSFT_FAIL to KSFT_SKIP for scenarios where the test cannot run because the kernel wasn't built withCONFIG_MEM_ALLOC_PROFILING.
Patches in v8 All 6 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | alloc_tag: add ioctl to /proc/allocinfoDocumentation/ Documentation/ MAINTAINERS +4 more | +329 | 0 replies | Applied |
| 2/6 | alloc_tag: add ioctl filters to /proc/allocinfoinclude/ mm/ | +89 | 0 replies | Applied |
| 3/6 | alloc_tag: add size-based filtering to ioctlinclude/ mm/ | +58 | 0 replies | Applied |
| 4/6 | alloc_tag: add accuracy based filtering to ioctlinclude/ mm/ | +12 | 0 replies | Applied |
| 5/6 | kselftest: alloc_tag: add kselftest for ioctl interfaceMAINTAINERS tools/ tools/ +1 more | +345 | 1 reply | Applied |
| 6/6 | kselftest: alloc_tag: extend the allocinfo ioctl kselftesttools/ | +215 | 1 reply | Applied |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Hao Ge | Suren Baghdasaryan |
|---|---|---|
| 1/6 | A-b | |
| 2/6 | A-b | A-b |
| 3/6 | A-b | A-b |
| 4/6 | A-b | A-b |
| 5/6 | T-b A-b | |
| 6/6 | T-b A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v8 0/6] alloc_tag: introduce IOCTL-based filtering for MAP
Currently, memory allocation profiling data is primarily exposed through /proc/allocinfo. While useful for manual inspection, this text-based interface poses challenges for production monitoring and large-scale analysis:
1. Userspace must parse large amounts of text to extract specific fields.
2. To find specific tags, userspace must read the entire dataset, requiring many context switches and high data copying.
3. The kernel currently aggregates per-CPU counters for every allocation size, even those the user intends to filter out immediately.
This series introduces a new IOCTL-based binary interface for allocinfo that supports kernel-side filtering. By allowing the user to specify a filter mask, we significantly reduce the work performed in-kernel and the amount of data transferred to userspace. The IOCTL mechanism was chosen for allocinfo to address the per-CPU counter aggregation bottleneck. A traditional read() operation must report the total allocation count and sizes for every code tag in the system. Doing so requires iterating across all CPUs to sum their per-CPU counters for thousands of tags, which introduces substantial runtime overhead.
The IOCTL interface allows userspace to push selective filtering criteria directly into the kernel before the per-CPU counter aggregation. The kernel aggregates per-CPU counters only for a small subset of tags that match the filter. This results in significant performance improvement.
Beyond fast filtered retrieval, the IOCTL foundation allows introducing a context capture mechanism in the future to capture the context for specific allocations.
Performance measurements were conducted on an Intel Xeon Platinum 8481C (224 CPUs) with caches dropped before each run.
The IOCTL mechanism shows a ~20x performance improvement for filtered queries. The kernel avoids the expensive per-CPU counter aggregation (alloc_tag_read) for any tags that fail the initial string or location filters.
Scenario 1: Specific File Filtering (arch/x86/events/rapl.c)
1. Traditional (cat /proc/allocinfo | grep): 22ms (sys)
2. IOCTL Interface: 1ms (sys)
Scenario 2: Compound Filtering (Filename + Size)
1. Traditional: (cat ... | grep | awk): 21ms (sys)
2. IOCTL Interface: 1ms (sys)
Scenario 3: Size-Based Filtering (min_size = 1MB)
1. Traditional: (cat ... | awk): 21ms (sys)
2. IOCTL Interface: 14ms (sys)
v8 changes:
- Patch 6/6: Changed KSFT_FAIL to KSFT_SKIP for scenarios where the test cannot run because the kernel wasn't built withCONFIG_MEM_ALLOC_PROFILING.
v7 changes:
- Patch 5/6: Used $KHDR_INCLUDES in the kselftest Makefile. Replaced goto statetments with break in get_filtered_ioctl_entries function.
- Patch 6/6: In test_size_filter, added a verification step to validate the size of the found tag matches target_size. In test_lineno_filter,
improved the comment, and verified that ioctl retrieves the original tag that was used to record target_lineno.
v6 changes:
- Patch 1/6: Added comments explaining why last 64 characters are compared in the filter.
- Patch 3/6: Moved allocinfo_prefetch_counters outside of allocinfo_to_params
- Patch 5/6: Fixed fd leak in get_filtered_ioctl_entries() function. Added alloc_tag selftest to the top-level Makefile.
- Patch 6/6: Moved include for errno.h to this patch.
v5 changes:
- Patch 1/6: Added explicit mutex_destroy.
- Patch 5/6: Self-contained file descriptors to avoid wrap-around errors in retry loops.
- Patch 6/6: Fixed minor issues raised by sashiko in v4.
v4 changes:
- Patch 1/6: Fixed a copyright comment inside include/uapi/linux/alloc_tag.h
- Patch 3/6: Among other nits, fixed the inadvertent build failure introduced in v3.
- Patch 4/6: Included a comment stating that the accurate field in struct allocinfo_tag is only used for filtering.
- Patch 5/6: Modified test to trim prefix and keep suffix for entries with filenames exceeding the size limit.
- Patch 6/6: Modified test_size_filter such that if content_id changes between the moment when procfs and ioctl entries are read, both
entries are invalidated and re-fetched. Removed the tags->count == 0 check from test_lineno_filter as it's virtually unreachable.
v3 changes:
- Patch 1/6: Modified Documentation to indicate that map supports ioctl(). Modified struct allocinfo_count to use
__attribute__((aligned(8))) instead of manual padding. Removed redundance type-casting. Added comments for static functions in lib/alloc_tag.c. Introduced a new seq counter for content_id that gets bumped every time module is loaded / unloaded. Introduced logic to validate user specified position is not greater than number of allocation tags and return early if it is. Changed strscpy to strscpy_pad to not echo arbitrary user data back to the user.
- Patch 2/6: Handled the case where user wants to specifically filter for built-in modules. Included some comments for static functions.
- Patch 3/6: Modified logic to only fetch per-CPU counters for codetags that satisfy other filters. Included some comments for static
functions.
v2 changes:
- Patch 1/6: Introduced locking for m->private. Also included the new uapi header file in MAINTAINERS list.
- Patch 2/6: Handled the case where ALLOCINFO_FILTER_MASK_MODNAME is passed but ct->modname is NULL.
- Patch 3/6: Moved min_size and max_size outside of struct allocinfo_tag into struct allocinfo_filter. Added validation that min_size <= max_size. Prefetched alloc_tag_counters if size based filter masks are provided to avoid assimilating per-cpu counters twice.
- Patch 5/6: Removed the hardcoded logic to skip the header, instead the test will skip lines that don't match the format. Also included the newly added alloc_tag selftests directory in MAINTAINERS list.
Abhishek Bapat (5):
alloc_tag: add ioctl filters to /proc/allocinfo
alloc_tag: add size-based filtering to ioctl
alloc_tag: add accuracy based filtering to ioctl
kselftest: alloc_tag: add kselftest for ioctl interface
kselftest: alloc_tag: extend the allocinfo ioctl kselftest
Suren Baghdasaryan (1):
alloc_tag: add ioctl to /proc/allocinfo
Documentation/mm/allocation-profiling.rst | 5 + .../userspace-api/ioctl/ioctl-number.rst | 2 + MAINTAINERS | 2 + include/linux/codetag.h | 2 + include/uapi/linux/alloc_tag.h | 99 ++++ lib/codetag.c | 18 + mm/alloc_tag.c | 344 ++++++++++- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/alloc_tag/Makefile | 9 + .../alloc_tag/allocinfo_ioctl_test.c | 548 ++++++++++++++++++ 10 files changed, 1028 insertions(+), 2 deletions(-) create mode 100644 include/uapi/linux/alloc_tag.h create mode 100644 tools/testing/selftests/alloc_tag/Makefile create mode 100644 tools/testing/selftests/alloc_tag/allocinfo_ioctl_test.c
base-commit: d11ba1f570615ec8d4814d6313ee1d7075a33787
Signature · 1 line
2.55.0.795.g602f6c329a-goog