Skip to content

btrfs: remove folio ordered flag

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Changes in v1 from the cover letter

- Replace the folio_test_ordered() inside extent_writepage_io() Now do the check inside alloc_new_bio(), which is already doing the OE search.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5btrfs: detect dirty blocks without an ordered extent more reliablyfs/btrfs/extent_io.c+54 -310 replies
2/5btrfs: unify folio dirty flag clearingfs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/inode.c+26 -131 reply
3/5btrfs: use dirty flag to check if an ordered extent needs to be truncatedfs/btrfs/inode.c+13 -80 replies
4/5btrfs: remove folio_test_ordered() usagefs/btrfs/extent_io.c fs/btrfs/inode.c+0 -130 replies
5/5btrfs: remove folio ordered flag and subpage bitmapfs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/fs.h +3 more+11 -960 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] btrfs: remove folio ordered flag

[CHANGELOG]
RFC->v1:
- Replace the folio_test_ordered() inside extent_writepage_io() Now do the check inside alloc_new_bio(), which is already doing the OE search.

Now we can detect dirty blocks without an OE at per-block level, much better than the previous per-folio level checks, and without any extra overhead.

Btrfs has a long history using an internal folio flag called ordered, which is to indicate if an fs block is covered by an ordered extent.

However this means we need to synchronize between ordered extents, which are managed by a per-inode ordered tree, and folio flag/subpage bitmap.

Furthermore with huge folio support, the ordered bitmap can be as large as 64 bytes (512 bits), which is not a small amount.

The series is going to remove folio ordered flag completely, along with the ordered subpage bitmap.

Most call sites of folio_test_ordered() are just inside ASSERT()s, so it's not too hard to remove them.

There are two call sites that utilizing *_folio_test_ordered():

- Inside extent_writepage_io()
The warning left by the legacy COW fixup mechanism.
The 1st patch is to introduce a more reliable way to detect dirty blocks without an OE, other than checking the folio ordered flag, now it's doing a per-block level check without introducing new overhead.

- Inside btrfs_invalidate_folio()
We use ordered flag to check if we can skip an ordered extent. This is worked around by using the fact that we have waited for writeback of the folio, so that endio should have already finished for the writeback range. Then check dirty flags to determine if we can skip the OE range.

To get a reliable dirty flag for both sub-folio and full-folio cases, we can not clear the folio dirty flag early, so the 2nd patch is introduced to change the folio dirty flag clearing timing, then the 3rd patch can remove the folio_test_ordered() usage.

Then the 4th patch is to remove the remaining folio_test_ordered() usage, and finally we can remove the whole ordered flag/subpage bitmap completely.

I tried to hide the ordered flag/bitmap behind DEBUG, but unfortunately the subpage bitmap macros are not that easy to be tweaked to handle conditional ordered flags.

So the ordered flag/bitmap must be either there, or be completely gone. I hope enough test runs will cover the removed ASSERT()s.

Qu Wenruo (5):
btrfs: detect dirty blocks without an ordered extent more reliably
btrfs: unify folio dirty flag clearing
btrfs: use dirty flag to check if an ordered extent needs to be
truncated
btrfs: remove folio_test_ordered() usage
btrfs: remove folio ordered flag and subpage bitmap

 fs/btrfs/extent_io.c | 117 ++++++++++++++++++++++++-------------------
 fs/btrfs/extent_io.h |  12 ++++-
 fs/btrfs/fs.h        |   8 ---
 fs/btrfs/inode.c     |  60 ++++++----------------
 fs/btrfs/subpage.c   |  41 +--------------
 fs/btrfs/subpage.h   |  19 +++----
 6 files changed, 100 insertions(+), 157 deletions(-)
Signature · 1 line
2.54.0