Skip to content

hw/nvme: add monitor commands for inspecting state

Mateusz Nowicki qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 1 replyIn review
  2. v3 posting 2/22 patches 2 repliesSuperseded
  3. v3 posting 1/22 patches 5 repliesApplied
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches1 replySuperseded
v12 patches7 repliesSuperseded

Changes in v4 from the cover letter

- Drop the v3 attempt to gate the new commands with 'if': 'CONFIG_NVME_PCI'. CONFIG_NVME_PCI is a device symbol and is poisoned in common code, so the generated qapi-introspect.c failed to build (reported by Klaus Jensen). Instead the x-query commands stay unconditional and hw/nvme/monitor-stub.c provides qmp_x_query_nvme[_queues]() stubs, built when CONFIG_NVME_PCI is not set, so targets without NVMe (e.g. riscv64-softmmu) link.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hw/nvme: add 'info nvme' HMP commandhmp-commands-info.hx hw/nvme/meson.build hw/nvme/monitor-stub.c +2 more+124 -10 replies
2/2hw/nvme: add 'info nvme-queues' HMP commandhmp-commands-info.hx hw/nvme/monitor-stub.c hw/nvme/monitor.c +1 more+101 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDr. David Alan GilbertMarkus Armbruster
1/2A-b A-b
2/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] hw/nvme: add monitor commands for inspecting state

Add two HMP commands for inspecting emulated NVMe controllers from the QEMU monitor without attaching gdb to the QEMU process:

- 'info nvme' - per-controller summary (PCI, identify
fields, CC/CSTS/AQA, queue counts)
- 'info nvme-queues' - per-queue listing of admin and I/O SQ/CQ (size, head/tail, PRP1, doorbell offset, phase tag)

Useful for verifying queue setup, doorbell rings, AERs held in the admin SQ and similar driver/controller interaction details from a running QEMU monitor.

Changes in v4:
- Drop the v3 attempt to gate the new commands with 'if': 'CONFIG_NVME_PCI'. CONFIG_NVME_PCI is a device symbol and is poisoned in common code, so the generated qapi-introspect.c failed to build (reported by Klaus Jensen). Instead the x-query commands stay unconditional and hw/nvme/monitor-stub.c provides qmp_x_query_nvme[_queues]() stubs, built when CONFIG_NVME_PCI is not set, so targets without NVMe (e.g. riscv64-softmmu) link.

Changes in v3:
- hw/nvme/meson.build: keep the source file list alphabetically sorted (Markus).

Changes in v2:
- hw/nvme/meson.build: add the missing trailing newline (Markus).
- Pick up Acked-by tags from Dr. David Alan Gilbert and Markus Armbruster on both patches.

v3: https://lore.kernel.org/qemu-devel/[email protected]/
v2: https://lore.kernel.org/qemu-devel/[email protected]/
v1: https://lore.kernel.org/qemu-devel/[email protected]/

Mateusz Nowicki (2):
hw/nvme: add 'info nvme' HMP command
hw/nvme: add 'info nvme-queues' HMP command

 hmp-commands-info.hx   |  28 +++++++++
 hw/nvme/meson.build    |   4 +-
 hw/nvme/monitor-stub.c |  21 +++++++
 hw/nvme/monitor.c      | 139 +++++++++++++++++++++++++++++++++++++++++
 qapi/machine.json      |  34 ++++++++++
 5 files changed, 225 insertions(+), 1 deletion(-)
 create mode 100644 hw/nvme/monitor-stub.c
 create mode 100644 hw/nvme/monitor.c
Signature · 1 line
2.53.0