hw/nvme: add monitor commands for inspecting state
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest2 patches 1 replyIn review
- v3 posting 2/22 patches 2 repliesSuperseded
- v3 posting 1/22 patches 5 repliesApplied
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 2 patches | 1 reply | Superseded | |
| v1 | 2 patches | 7 replies | Superseded |
Changes in v4 from the cover letter
- Drop the v3 attempt to gate the new commands with 'if': 'CONFIG_NVME_PCI'. CONFIG_NVME_PCI is a device symbol and is poisoned in common code, so the generated qapi-introspect.c failed to build (reported by Klaus Jensen). Instead the x-query commands stay unconditional and hw/nvme/monitor-stub.c provides qmp_x_query_nvme[_queues]() stubs, built when CONFIG_NVME_PCI is not set, so targets without NVMe (e.g. riscv64-softmmu) link.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | hw/nvme: add 'info nvme' HMP commandhmp-commands-info.hx hw/ hw/ +2 more | +124 | 0 replies | |
| 2/2 | hw/nvme: add 'info nvme-queues' HMP commandhmp-commands-info.hx hw/ hw/ +1 more | +101 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Dr. David Alan Gilbert | Markus Armbruster |
|---|---|---|
| 1/2 | A-b | A-b |
| 2/2 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/2] hw/nvme: add monitor commands for inspecting state
Add two HMP commands for inspecting emulated NVMe controllers from the QEMU monitor without attaching gdb to the QEMU process:
- 'info nvme' - per-controller summary (PCI, identify
fields, CC/CSTS/AQA, queue counts)
- 'info nvme-queues' - per-queue listing of admin and I/O SQ/CQ (size, head/tail, PRP1, doorbell offset, phase tag)
Useful for verifying queue setup, doorbell rings, AERs held in the admin SQ and similar driver/controller interaction details from a running QEMU monitor.
Changes in v4:
- Drop the v3 attempt to gate the new commands with 'if': 'CONFIG_NVME_PCI'. CONFIG_NVME_PCI is a device symbol and is poisoned in common code, so the generated qapi-introspect.c failed to build (reported by Klaus Jensen). Instead the x-query commands stay unconditional and hw/nvme/monitor-stub.c provides qmp_x_query_nvme[_queues]() stubs, built when CONFIG_NVME_PCI is not set, so targets without NVMe (e.g. riscv64-softmmu) link.
Changes in v3:
- hw/nvme/meson.build: keep the source file list alphabetically sorted (Markus).
Changes in v2:
- hw/nvme/meson.build: add the missing trailing newline (Markus).
- Pick up Acked-by tags from Dr. David Alan Gilbert and Markus Armbruster on both patches.
v3: https://lore.kernel.org/qemu-devel/[email protected]/
v2: https://lore.kernel.org/qemu-devel/[email protected]/
v1: https://lore.kernel.org/qemu-devel/[email protected]/
Mateusz Nowicki (2):
hw/nvme: add 'info nvme' HMP command
hw/nvme: add 'info nvme-queues' HMP command
hmp-commands-info.hx | 28 +++++++++ hw/nvme/meson.build | 4 +- hw/nvme/monitor-stub.c | 21 +++++++ hw/nvme/monitor.c | 139 +++++++++++++++++++++++++++++++++++++++++ qapi/machine.json | 34 ++++++++++ 5 files changed, 225 insertions(+), 1 deletion(-) create mode 100644 hw/nvme/monitor-stub.c create mode 100644 hw/nvme/monitor.c
Signature · 1 line
2.53.0