Skip to content

drm/{i915, xe}/panic: drop dependency on struct intel_framebuffer

Jani Nikula intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/i915/panic: split out i915_gem_panic.[ch]drivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gem/i915_gem_object.h drivers/gpu/drm/i915/gem/i915_gem_pages.c +3 more+155 -1362 replies
2/6drm/i915/panic: squash i915_panic.c into i915_gem_panic.cdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gem/i915_gem_panic.c drivers/gpu/drm/i915/gem/i915_gem_panic.h +3 more+32 -591 reply
3/6drm/i915/panic: remove the extra layer from panic hooksdrivers/gpu/drm/i915/gem/i915_gem_panic.c+7 -231 reply
4/6drm/{i915,xe}/panic: pass obj to panic setupdrivers/gpu/drm/i915/display/intel_parent.c drivers/gpu/drm/i915/display/intel_parent.h drivers/gpu/drm/i915/display/intel_plane.c +3 more+13 -111 reply
5/6drm/xe/panic: store fb bo in struct intel_panicdrivers/gpu/drm/xe/display/xe_panic.c+5 -21 reply
6/6drm/{i915, xe}/panic: drop dependency on struct intel_framebufferdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_parent.c drivers/gpu/drm/i915/display/intel_parent.h +4 more+35 -261 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJocelyn Falempe
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] drm/{i915, xe}/panic: drop dependency on struct intel_framebuffer

Having i915 and xe panic code depend on struct intel_framebuffer is a bit annoying. Break that dependency by storing the tiling function pointer in struct intel_panic, and storing intel_panic pointer in struct drm_scanout_buffer .private member. Do a bunch of cleanups first to make it easier.

Cc Jocelyn Falempe <[email protected]>

Jani Nikula (6):
drm/i915/panic: split out i915_gem_panic.[ch] drm/i915/panic: squash i915_panic.c into i915_gem_panic.c drm/i915/panic: remove the extra layer from panic hooks drm/{i915,xe}/panic: pass obj to panic setup drm/xe/panic: store fb bo in struct intel_panic drm/{i915,xe}/panic: drop dependency on struct intel_framebuffer

 drivers/gpu/drm/i915/Makefile                 |   4 +-
 .../drm/i915/display/intel_display_types.h    |   1 -
 drivers/gpu/drm/i915/display/intel_parent.c   |   6 +-
 drivers/gpu/drm/i915/display/intel_parent.h   |   4 +-
 drivers/gpu/drm/i915/display/intel_plane.c    |   8 +-
 drivers/gpu/drm/i915/gem/i915_gem_object.h    |   7 -
 drivers/gpu/drm/i915/gem/i915_gem_pages.c     | 128 ---------------
 drivers/gpu/drm/i915/gem/i915_gem_panic.c     | 147 ++++++++++++++++++
 drivers/gpu/drm/i915/gem/i915_gem_panic.h     |  11 ++
 drivers/gpu/drm/i915/i915_driver.c            |   2 +-
 drivers/gpu/drm/i915/i915_panic.c             |  35 -----
 drivers/gpu/drm/i915/i915_panic.h             |   9 --
 drivers/gpu/drm/xe/display/xe_panic.c         |  26 ++--
 include/drm/intel/display_parent_interface.h  |   4 +-
 14 files changed, 191 insertions(+), 201 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_panic.c
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_panic.h
 delete mode 100644 drivers/gpu/drm/i915/i915_panic.c
 delete mode 100644 drivers/gpu/drm/i915/i915_panic.h
Signature · 1 line
2.47.3