Skip to content

Enable lock context analysis in drivers/block/

Bart Van Assche linux-block 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest27 patches 35 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/27aoe: Enable lock context analysisdrivers/block/aoe/Makefile drivers/block/aoe/aoecmd.c+3 -01 reply
2/27drbd: Remove "extern" from function declarationsdrivers/block/drbd/drbd_config.h drivers/block/drbd/drbd_int.h drivers/block/drbd/drbd_interval.h +3 more+346 -3341 reply
3/27drbd: Retain one _get_ldev_if_state() implementationdrivers/block/drbd/drbd_int.h drivers/block/drbd/drbd_main.c+2 -241 reply
4/27drbd: Remove the get_ldev_if_state() macrodrivers/block/drbd/drbd_int.h+2 -51 reply
5/27drbd: Remove the 'local' lock contextdrivers/block/drbd/drbd_bitmap.c drivers/block/drbd/drbd_int.h drivers/block/drbd/drbd_main.c +3 more+55 -661 reply
6/27drbd: Simplify the bitmap locking functions.drivers/block/drbd/drbd_bitmap.c+1 -191 reply
7/27drbd: Move two declarationsdrivers/block/drbd/drbd_int.h+2 -31 reply
8/27drbd: Pass 'resource' directly to complete_conflicting_writes()drivers/block/drbd/drbd_req.c+5 -41 reply
9/27drbd: Split drbd_nl_get_connections_dumpit()drivers/block/drbd/drbd_nl.c+55 -432 replies
10/27drbd: Make a mutex_unlock() call unconditionaldrivers/block/drbd/drbd_nl.c+9 -51 reply
11/27drbd: Split drbd_req_state()drivers/block/drbd/drbd_state.c+28 -153 replies
12/27drbd: Convert drbd_req_state() to unconditional lockingdrivers/block/drbd/drbd_state.c+5 -41 reply
13/27drbd: Annotate drbd_bm_{lock,unlock}()drivers/block/drbd/drbd_bitmap.c drivers/block/drbd/drbd_int.h+12 -21 reply
14/27drbd: Enable lock context analysisdrivers/block/drbd/Makefile drivers/block/drbd/drbd_int.h drivers/block/drbd/drbd_main.c +4 more+34 -110 replies
15/27loop: Split loop_change_fd()drivers/block/loop.c+46 -391 reply
16/27loop: Split loop_configure()drivers/block/loop.c+57 -522 replies
17/27loop: Remove the "bool global" function argumentdrivers/block/loop.c+40 -270 replies
18/27loop: Add lock context annotationsdrivers/block/loop.c+4 -03 replies
19/27mtip32: Enable lock context analysisdrivers/block/mtip32xx/Makefile+2 -00 replies
20/27nbd: Enable lock context analysisdrivers/block/nbd.c+3 -03 replies
21/27null_blk: Enable lock context analysisdrivers/block/null_blk/Makefile drivers/block/null_blk/main.c drivers/block/null_blk/zoned.c+12 -44 replies
22/27rbd: Enable lock context analysisdrivers/block/rbd.c+8 -01 reply
23/27ublk: Enable lock context analysisdrivers/block/ublk_drv.c+6 -01 reply
24/27xen-blkback: Enable lock context analysisdrivers/block/xen-blkback/Makefile+3 -00 replies
25/27zram: Enable lock context analysisdrivers/block/zram/Makefile drivers/block/zram/zcomp.c drivers/block/zram/zcomp.h+8 -30 replies
26/27rnbd: Enable lock context analysisdrivers/block/rnbd/Makefile+2 -00 replies
27/27block: Enable lock context analysis for all block driversdrivers/block/Makefile+2 -00 replies

Reviews trailers per patch

17 of 27 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigRoger Pau MonnéSergey SenozhatskyJack WangDamien Le MoalMing LeiNilay ShroffMd Haris Iqbal
1/27R-b R-b
2/27R-b
3/27R-b
4/27R-b
5/27R-b
6/27R-b
7/27R-b
8/27R-b
9/27
10/27R-b
11/27
12/27
13/27R-b
14/27
15/27
16/27
17/27
18/27
19/27R-b
20/27R-b
21/27R-b R-b
22/27
23/27R-b
24/27A-b
25/27R-b
26/27A-b
27/27

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v1 thread

Cover letter [PATCH 00/27] Enable lock context analysis in drivers/block/

Hi Jens,

This patch series enables lock context analysis in all block drivers in the drivers/block/ directory. Please consider these patches for the next merge window.

Thanks,

Bart.

Bart Van Assche (27):
aoe: Enable lock context analysis
drbd: Remove "extern" from function declarations
drbd: Retain one _get_ldev_if_state() implementation
drbd: Remove the get_ldev_if_state() macro
drbd: Remove the 'local' lock context
drbd: Simplify the bitmap locking functions.
drbd: Move two declarations
drbd: Pass 'resource' directly to complete_conflicting_writes()
drbd: Split drbd_nl_get_connections_dumpit()
drbd: Make a mutex_unlock() call unconditional
drbd: Split drbd_req_state()
drbd: Convert drbd_req_state() to unconditional locking
drbd: Annotate drbd_bm_{lock,unlock}()
drbd: Enable lock context analysis
loop: Split loop_change_fd()
loop: Split loop_configure()
loop: Remove the "bool global" function argument
loop: Add lock context annotations
mtip32: Enable lock context analysis
nbd: Enable lock context analysis
null_blk: Enable lock context analysis
rbd: Enable lock context analysis
ublk: Enable lock context analysis
xen-blkback: Enable lock context analysis
zram: Enable lock context analysis
rnbd: Enable lock context analysis
block: Enable lock context analysis for all block drivers

 drivers/block/Makefile                 |   2 +
 drivers/block/aoe/Makefile             |   2 +
 drivers/block/aoe/aoecmd.c             |   1 +
 drivers/block/drbd/Makefile            |   3 +
 drivers/block/drbd/drbd_bitmap.c       |  43 +-
 drivers/block/drbd/drbd_config.h       |   2 +-
 drivers/block/drbd/drbd_int.h          | 594 +++++++++++++------------
 drivers/block/drbd/drbd_interval.h     |  11 +-
 drivers/block/drbd/drbd_main.c         |  41 +-
 drivers/block/drbd/drbd_nl.c           | 117 ++---
 drivers/block/drbd/drbd_receiver.c     |  27 +-
 drivers/block/drbd/drbd_req.c          |  10 +-
 drivers/block/drbd/drbd_req.h          |  24 +-
 drivers/block/drbd/drbd_state.c        |  50 ++-
 drivers/block/drbd/drbd_state.h        |  41 +-
 drivers/block/drbd/drbd_state_change.h |  32 +-
 drivers/block/drbd/drbd_worker.c       |   6 +-
 drivers/block/loop.c                   | 251 ++++++-----
 drivers/block/mtip32xx/Makefile        |   2 +
 drivers/block/nbd.c                    |   3 +
 drivers/block/null_blk/Makefile        |   2 +
 drivers/block/null_blk/main.c          |  12 +-
 drivers/block/null_blk/zoned.c         |   2 +
 drivers/block/rbd.c                    |   8 +
 drivers/block/rnbd/Makefile            |   2 +
 drivers/block/ublk_drv.c               |   6 +
 drivers/block/xen-blkback/Makefile     |   3 +
 drivers/block/zram/Makefile            |   2 +
 drivers/block/zram/zcomp.c             |   3 +-
 drivers/block/zram/zcomp.h             |   6 +-
 30 files changed, 700 insertions(+), 608 deletions(-)