Skip to content

rv/reactors: fix lockdep warning and add tests

[email protected] linux-trace-kernel lkml 6 versions – Applied

Status from this message: Applied to my tree, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 1 replyApplied
  2. v55 patches 3 repliesSuperseded
  3. v44 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v34 patches10 repliesSuperseded
v24 patches7 repliesSuperseded
v13 patches23 repliesSuperseded

Changes in v5 from the cover letter

- Patch 1: Fix typo. Functional code unchanged.
- Patch 2: Unchanged.
- Patch 3: Only exported the registration helpers as v4.
- Patch 4: Fix typo. Functional code unchanged.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/4rv/reactors: use LD_WAIT_SPIN as the reactor lockdep wait typekernel/trace/rv/rv_reactors.c+9 -10 replies
2/4rv/reactors: propagate rv_register_reactor() error from reactor initkernel/trace/rv/reactor_panic.c kernel/trace/rv/reactor_printk.c+2 -40 replies
3/4rv/reactors: export rv_register_reactor() and rv_unregister_reactor()kernel/trace/rv/rv_reactors.c+2 -00 replies
4/4rv/reactors: add KUnit tests for reactor registration and dispatchkernel/trace/rv/Kconfig kernel/trace/rv/Makefile kernel/trace/rv/rv_reactors_kunit.c+124 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchGabriele MonacoNam Cao
1/4R-b
2/4R-b R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/4] rv/reactors: fix lockdep warning and add tests

From: Wen Yang <[email protected]>

We occasionally hit a lockdep "Invalid wait context" warning when a reactor callback is preempted by a timer interrupt.
On interrupt exit the scheduler takes rq->__lock (LD_WAIT_SPIN) while rv_react() still holds its wait-type-override map, which declared LD_WAIT_FREE. On any kernel where the task context has preemption enabled (not just CONFIG_PREEMPT_RT) this triggers a spurious lockdep report:

[ BUG: Invalid wait context ]
1 lock held by kunit_try_catch/209:
#0: (rv_react_map-wait-type-override){+.+.}-{1:1}
kunit_try_catch/209 is trying to lock:
ffff8a743ed3e8a0 (&rq->__lock){-...}-{2:2}

This series fixes the wait type (patch 1), makes reactor registration failures propagate (patch 2), adds support for module-based reactors (patch 3), and adds KUnit/kselftest coverage (patch 4-5).

Changes in v5:
- Patch 1: Fix typo. Functional code unchanged.
- Patch 2: Unchanged.
- Patch 3: Only exported the registration helpers as v4.
- Patch 4: Fix typo. Functional code unchanged.

v5: https://lore.kernel.org/lkml/[email protected]/
v4: https://lore.kernel.org/lkml/[email protected]/
v3: https://lore.kernel.org/lkml/[email protected]/
v2: https://lore.kernel.org/lkml/[email protected]/
v1: https://lore.kernel.org/lkml/[email protected]/

Wen Yang (4):
rv/reactors: use LD_WAIT_SPIN as the reactor lockdep wait type rv/reactors: propagate rv_register_reactor() error from reactor init rv/reactors: export rv_register_reactor() and rv_unregister_reactor() rv/reactors: add KUnit tests for reactor registration and dispatch

 kernel/trace/rv/Kconfig             |  12 +++
 kernel/trace/rv/Makefile            |   1 +
 kernel/trace/rv/reactor_panic.c     |   3 +-
 kernel/trace/rv/reactor_printk.c    |   3 +-
 kernel/trace/rv/rv_reactors.c       |  12 ++-
 kernel/trace/rv/rv_reactors_kunit.c | 111 ++++++++++++++++++++++++++++
 6 files changed, 137 insertions(+), 5 deletions(-)
 create mode 100644 kernel/trace/rv/rv_reactors_kunit.c
Signature · 1 line
2.25.1