Skip to content

thunderbold: A few cleanups

Uwe Kleine-König (The Capable Hub) linux-usb lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3thunderbold: Stop passing matched device ID to .probe()drivers/net/thunderbolt/main.c drivers/thunderbolt/dma_test.c drivers/thunderbolt/domain.c +2 more+5 -70 replies
2/3thunderbold: Assert that a service driver has a probe callbackdrivers/thunderbolt/xdomain.c+3 -00 replies
3/3thunderbold: Drop comma after device id array terminatordrivers/net/thunderbolt/main.c drivers/thunderbolt/dma_test.c drivers/thunderbolt/stream.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/3] thunderbold: A few cleanups

Hello,

I'm currently working on a project that includes looking at all device ID structures from <linux/mod_devicetable.h>. While doing that for tb_service_id, I spotted these patch opportunities.

These are all non-critical and also my quest doesn't depend on this, so there is no urge to apply these patches. My suggestion is to apply them via the thunderbold tree during the next merge window with an ack from the network guys.

The first patch touches drivers/net and drivers/thunderbold. It could theretically be split, but then this results in at least 3 commits which seems excessive to handle three drivers, so I kept it as a single patch.

The third patch is a style change and so is subjective. Drop it, if you don't like it. Here splitting would be easy, but given that patch #1 already touches the same files, letting these go in together without splitting seems to be sensible.

Best regards
Uwe

Uwe Kleine-König (The Capable Hub) (3):
thunderbold: Stop passing matched device ID to .probe()
thunderbold: Assert that a service driver has a probe callback
thunderbold: Drop comma after device id array terminator

 drivers/net/thunderbolt/main.c | 4 ++--
 drivers/thunderbolt/dma_test.c | 4 ++--
 drivers/thunderbolt/domain.c   | 4 +---
 drivers/thunderbolt/stream.c   | 4 ++--
 drivers/thunderbolt/xdomain.c  | 3 +++
 include/linux/thunderbolt.h    | 2 +-
 6 files changed, 11 insertions(+), 10 deletions(-)

base-commit: 4fa3f5fabb30bf00d7475d5a33459ea83d639bf9

Signature · 1 line
2.47.3