nfs: refactor bit operations using clear_and_wake_up_bit
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | nfs: replace atomic bitops sequence with clear_and_wake_up_bit helperfs/ | +1 | 0 replies | |
| 2/2 | nfs: refactor pNFS functions using clear_and_wake_up_bitfs/ | +10 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] nfs: refactor bit operations using clear_and_wake_up_bit
Several functions in nfs code use the exact following sequence of calls when dealing with flags:
clear_bit_unlock(); smp_mb__after_atomic(); wake_up_bit();
Since commit 8236b0ae31c8 ("bdi: wake up concurrent wb_shutdown() callers.") came the helper clear_and_wake_up_bit() for this exact purpose, and has since been adopted by several subsystems, including vfs.
This function is already used in files such as nfs4state.c and pnfs_nfs.c and this serie aims to continue this effort, which also allows to remove some no longer used code.
Tested on x86 hardware using a loopback pNFS SCSI layout:
* doing image compression/decompression using xz and
* recompiling tinyconfig kernels on the remounted partition No error reported under sanitizers.
---
Arnaud Bonnet (2):
nfs: replace atomic bitops sequence with clear_and_wake_up_bit helper
nfs: refactor pNFS functions using clear_and_wake_up_bit
fs/nfs/inode.c | 4 +--- fs/nfs/pnfs.c | 35 ++++++++++------------------------- 2 files changed, 11 insertions(+), 28 deletions(-)
Signature · 1 line
2.53.0