Skip to content

tools: remove unnecessary shared library dependencies from standalone tools

Sebastian Brzezinka igt-dev 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 0 repliesNew
  2. v431 patches 6 repliesApplied
  3. v331 patches 33 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v231 patches38 repliesSuperseded
v125 patches11 repliesSuperseded

Changes in v5 from the cover letter

- lib/igt_core: move igt_load_igtrc to igt_rc: add missing #include "igt_rc.h" to tools/lsgpu.c in this patch so lsgpu.c keeps compiling standalone (bisectability), instead of only fixing it in the next patch

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2lib/igt_core: move igt_load_igtrc to igt_rclib/igt_core.c lib/igt_core.h lib/igt_rc.c +4 more+69 -500 replies
2/2tools/lsgpu: link with minimal sub-librariestools/lsgpu.c tools/meson.build+7 -20 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAshutosh DixitKrzysztof NiemiecKrzysztof Karas
1/2R-b
2/2A-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH i-g-t v5 0/2] tools: remove unnecessary shared library dependencies from standalone tools

This is the tail end of the "tools: remove unnecessary shared library dependencies from standalone tools" series. Patches 1-29 of v4 have already been merged; these are the 2 remaining patches, rebased on current main and resent as v5.

igt_load_igtrc() is moved to igt_rc.c so lsgpu can use lib_igt_device_scan without pulling in libigt.so.

v4 -> v5:
- lib/igt_core: move igt_load_igtrc to igt_rc: add missing #include "igt_rc.h" to tools/lsgpu.c in this patch so lsgpu.c keeps compiling standalone (bisectability), instead of only fixing it in the next patch

Sebastian Brzezinka (2):
lib/igt_core: move igt_load_igtrc to igt_rc
tools/lsgpu: link with minimal sub-libraries

 lib/igt_core.c    | 47 -----------------------------------
 lib/igt_core.h    |  2 --
 lib/igt_rc.c      | 62 +++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_rc.h      |  2 ++
 lib/meson.build   |  4 ++-
 runner/executor.c |  1 +
 tools/lsgpu.c     |  3 ++-
 tools/meson.build |  7 +++++-
 8 files changed, 76 insertions(+), 52 deletions(-)
 create mode 100644 lib/igt_rc.c
Signature · 1 line
2.53.0