Skip to content

nfc: Various cleanups around device_id arrays

Uwe Kleine-König (The Capable Hub) linux-wireless lkml oe-linux-nfc 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12nfc: Drop __maybe_unused from acpi_device_id tablesdrivers/nfc/pn544/i2c.c drivers/nfc/st-nci/i2c.c drivers/nfc/st-nci/spi.c +1 more+4 -40 replies
2/12nfc: Drop unused assignment of acpi_device_id driver datadrivers/nfc/fdp/i2c.c drivers/nfc/pn544/i2c.c drivers/nfc/st-nci/spi.c +1 more+4 -50 replies
3/12nfc: Initialize acpi_device_id arrays using member namesdrivers/nfc/fdp/i2c.c drivers/nfc/nxp-nci/i2c.c drivers/nfc/pn544/i2c.c +3 more+9 -91 reply
4/12nfc: Unify style of acpi_device_id arraysdrivers/nfc/fdp/i2c.c drivers/nfc/pn544/i2c.c drivers/nfc/st-nci/i2c.c +2 more+5 -50 replies
5/12nfc: pn544: Drop empty line between i2c_device_id array and MODULE_DEVICE_TABLE()drivers/nfc/pn544/i2c.c+0 -10 replies
6/12nfc: Initialize mei_cl_device_idarrays using member namesdrivers/nfc/microread/mei.c drivers/nfc/pn544/mei.c+12 -80 replies
7/12nfc: Drop __maybe_unused from of_device_id tablesdrivers/nfc/nfcmrvl/i2c.c drivers/nfc/nfcmrvl/spi.c drivers/nfc/pn533/i2c.c +7 more+10 -102 replies
8/12nfc: Unify style of of_device_id arraysdrivers/nfc/nfcmrvl/i2c.c drivers/nfc/nfcmrvl/spi.c drivers/nfc/nxp-nci/i2c.c +10 more+30 -311 reply
9/12nfc: Drop unused assignment of spi_device_id driver datadrivers/nfc/nfcmrvl/spi.c drivers/nfc/st-nci/spi.c drivers/nfc/st95hf/core.c +1 more+5 -50 replies
10/12nfc: Initialize spi_device_idarrays using member namesdrivers/nfc/nfcmrvl/spi.c drivers/nfc/st-nci/spi.c drivers/nfc/st95hf/core.c +1 more+5 -50 replies
11/12nfc: Unify style of spi_device_id arraysdrivers/nfc/st-nci/spi.c drivers/nfc/st95hf/core.c drivers/nfc/trf7970a.c+3 -40 replies
12/12nfc: Unify style of usb_device_id arraysdrivers/nfc/nfcmrvl/usb.c drivers/nfc/port100.c+2 -30 replies

Reviews trailers per patch

2 of 12 patches have a Reviewed-by or Acked-by.

PatchIan Ray
1/12
2/12
3/12R-b
4/12
5/12
6/12
7/12
8/12R-b
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 00/12] nfc: Various cleanups around device_id arrays

Hello,

this series's objective is to convert device_id arrays of various different device types to named initialisation. It contains a few cleanups left and right that I spotted while working on these changes.

The follow up change is to replace .driver_data by an anonymous union, see
https://lore.kernel.org/all/[email protected]/
for the idea.

The changes here are not strictly necessary for my quest, but they align the device_id structures to how they look and will look for other subsystems.

Best regards
Uwe

Uwe Kleine-König (The Capable Hub) (12):
nfc: Drop __maybe_unused from acpi_device_id tables
nfc: Drop unused assignment of acpi_device_id driver data
nfc: Initialize acpi_device_id arrays using member names
nfc: Unify style of acpi_device_id arrays
nfc: pn544: Drop empty line between i2c_device_id array and
MODULE_DEVICE_TABLE()
nfc: Initialize mei_cl_device_idarrays using member names
nfc: Drop __maybe_unused from of_device_id tables
nfc: Unify style of of_device_id arrays
nfc: Drop unused assignment of spi_device_id driver data
nfc: Initialize spi_device_idarrays using member names
nfc: Unify style of spi_device_id arrays
nfc: Unify style of usb_device_id arrays

 drivers/nfc/fdp/i2c.c       |  4 ++--
 drivers/nfc/microread/mei.c | 10 ++++++----
 drivers/nfc/nfcmrvl/i2c.c   |  6 +++---
 drivers/nfc/nfcmrvl/spi.c   |  8 ++++----
 drivers/nfc/nfcmrvl/usb.c   |  1 -
 drivers/nfc/nxp-nci/i2c.c   | 10 +++++-----
 drivers/nfc/pn533/i2c.c     | 10 +++++-----
 drivers/nfc/pn533/uart.c    |  4 ++--
 drivers/nfc/pn544/i2c.c     | 14 ++++++--------
 drivers/nfc/pn544/mei.c     | 10 ++++++----
 drivers/nfc/port100.c       |  4 ++--
 drivers/nfc/s3fwrn5/i2c.c   |  6 +++---
 drivers/nfc/s3fwrn5/uart.c  |  4 ++--
 drivers/nfc/st-nci/i2c.c    | 18 +++++++++---------
 drivers/nfc/st-nci/spi.c    | 18 +++++++++---------
 drivers/nfc/st21nfca/i2c.c  | 14 +++++++-------
 drivers/nfc/st95hf/core.c   |  8 ++++----
 drivers/nfc/trf7970a.c      | 12 +++++-------
 18 files changed, 80 insertions(+), 81 deletions(-)

base-commit: 6eb8711ece2ce27e52e327a5b7a628ed39b97f45

Signature · 1 line
2.55.0.11.g153666a7d9bb