Skip to content

Enable lock context analysis in drivers/block/

Bart Van Assche linux-block 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 24 repliesIn review
  2. v112 patches 1 replySuperseded

Changes in v2 from the cover letter

- Moved the DRBD changes into a separate patch series.
- Combined two patches for the loop driver into a single patch.
- Also for the loop driver, added a __must_hold() annotation to __loop_change_fd() and __loop_configure(). Added a __guarded_by() annotation to loop_index_idr.
- Added a __guarded_by() annotation to nbd_index_idr.
- Introduced the null_zone locking "class" in the null_blk driver.
- Fixed the rbd patch description.
- Added a __cond_acquires() annotation to a new function in the ublk driver.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12aoe: Enable lock context analysisdrivers/block/aoe/Makefile drivers/block/aoe/aoecmd.c+3 -03 replies
2/12loop: Remove the "bool global" function argumentdrivers/block/loop.c+138 -1113 replies
3/12loop: Add lock context annotationsdrivers/block/loop.c+6 -13 replies
4/12mtip32: Enable lock context analysisdrivers/block/mtip32xx/Makefile+2 -01 reply
5/12nbd: Enable lock context analysisdrivers/block/nbd.c+9 -25 replies
6/12null_blk: Enable lock context analysisdrivers/block/null_blk/Makefile drivers/block/null_blk/main.c drivers/block/null_blk/zoned.c+57 -693 replies
7/12rbd: Enable lock context analysisdrivers/block/rbd.c+8 -05 replies
8/12ublk: Enable lock context analysisdrivers/block/ublk_drv.c+7 -00 replies
9/12xen-blkback: Enable lock context analysisdrivers/block/xen-blkback/Makefile+3 -00 replies
10/12zram: Enable lock context analysisdrivers/block/zram/Makefile drivers/block/zram/zcomp.c drivers/block/zram/zcomp.h+8 -30 replies
11/12rnbd: Enable lock context analysisdrivers/block/rnbd/Makefile+2 -00 replies
12/12block: Enable lock context analysis for all block driversdrivers/block/Makefile+2 -00 replies

Reviews trailers per patch

5 of 12 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigRoger Pau MonnéSergey SenozhatskyJack WangNilay Shroff
1/12R-b
2/12
3/12
4/12R-b R-b
5/12
6/12
7/12
8/12
9/12A-b
10/12R-b
11/12A-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/12] Enable lock context analysis in drivers/block/

Hi Jens,

This patch series enables lock context analysis in all block drivers in the drivers/block/ directory except DRBD. Please consider these patches for the next merge window.

Thank you,

Bart.

Changes compared to v1:
- Moved the DRBD changes into a separate patch series.
- Combined two patches for the loop driver into a single patch.
- Also for the loop driver, added a __must_hold() annotation to __loop_change_fd() and __loop_configure(). Added a __guarded_by() annotation to loop_index_idr.
- Added a __guarded_by() annotation to nbd_index_idr.
- Introduced the null_zone locking "class" in the null_blk driver.
- Fixed the rbd patch description.
- Added a __cond_acquires() annotation to a new function in the ublk driver.

Bart Van Assche (12):
aoe: Enable lock context analysis
loop: Remove the "bool global" function argument
loop: Add lock context annotations
mtip32: Enable lock context analysis
nbd: Enable lock context analysis
null_blk: Enable lock context analysis
rbd: Enable lock context analysis
ublk: Enable lock context analysis
xen-blkback: Enable lock context analysis
zram: Enable lock context analysis
rnbd: Enable lock context analysis
block: Enable lock context analysis for all block drivers

 drivers/block/Makefile             |   2 +
 drivers/block/aoe/Makefile         |   2 +
 drivers/block/aoe/aoecmd.c         |   1 +
 drivers/block/loop.c               | 256 ++++++++++++++++-------------
 drivers/block/mtip32xx/Makefile    |   2 +
 drivers/block/nbd.c                |  11 +-
 drivers/block/null_blk/Makefile    |   2 +
 drivers/block/null_blk/main.c      |   4 +
 drivers/block/null_blk/zoned.c     | 120 ++++++--------
 drivers/block/rbd.c                |   8 +
 drivers/block/rnbd/Makefile        |   2 +
 drivers/block/ublk_drv.c           |   7 +
 drivers/block/xen-blkback/Makefile |   3 +
 drivers/block/zram/Makefile        |   2 +
 drivers/block/zram/zcomp.c         |   3 +-
 drivers/block/zram/zcomp.h         |   6 +-
 16 files changed, 245 insertions(+), 186 deletions(-)