Skip to content

platform/x86: hp-wmi: Fix WMI error handling

Emre Cecanpunar lkml platform-driver-x86 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5platform/x86: hp-wmi: validate WMI response header sizedrivers/platform/x86/hp/hp-wmi.c+5 -01 reply
2/5platform/x86: hp-wmi: handle firmware errors in tablet mode querydrivers/platform/x86/hp/hp-wmi.c+17 -91 reply
3/5platform/x86: hp-wmi: handle errors in the OMEN key eventdrivers/platform/x86/hp/hp-wmi.c+6 -21 reply
4/5platform/x86: hp-wmi: normalize GPU thermal mode errorsdrivers/platform/x86/hp/hp-wmi.c+12 -91 reply
5/5platform/x86: hp-wmi: report fan speed command failuresdrivers/platform/x86/hp/hp-wmi.c+3 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] platform/x86: hp-wmi: Fix WMI error handling

Fix several places where hp-wmi either trusts an undersized firmware response or mistakes a positive HP firmware error for success.

The affected paths handle the common WMI response header, tablet-mode switch updates, the OMEN key event, Victus GPU thermal modes and Victus fan-speed control. Each patch is independent and can be applied on its own.

Emre Cecanpunar (5):
platform/x86: hp-wmi: validate WMI response header size platform/x86: hp-wmi: handle firmware errors in tablet mode query platform/x86: hp-wmi: handle errors in the OMEN key event platform/x86: hp-wmi: normalize GPU thermal mode errors platform/x86: hp-wmi: report fan speed command failures

 drivers/platform/x86/hp/hp-wmi.c | 64 +++++++++++++++++++++-----------
 1 file changed, 43 insertions(+), 21 deletions(-)

base-commit: 2b3a5dabe89e330413af403246b648c1890f368f