Skip to content

rtc: pcf8563: HYM8563 support and unreliable-time reporting

Daniel Golle u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2rtc: pcf8563: add haoyu,hym8563 compatibledrivers/rtc/pcf8563.c+1 -01 reply
2/2rtc: pcf8563: return -EINVAL when the voltage-low flag is setdrivers/rtc/pcf8563.c+2 -10 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchTom Rini
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] rtc: pcf8563: HYM8563 support and unreliable-time reporting

The Haoyu HYM8563, found for example on the Radxa ROCK 5B, is a clone of the NXP PCF8563 with an identical timekeeping register layout, but the pcf8563 driver does not match its compatible used in upstream DT.

Boards fitted with it end up without DM_RTC and, as a consequence, without usable EFI GetTime and SetTime runtime services. On top of that, when the chip reports that the time may be unreliable after a supply voltage drop, the driver returns a bare -1, which callers interpret as -EPERM rather than as invalid data.

This series makes the existing driver serve the HYM8563 and lets callers distinguish an unreliable time from a permission problem.

The driver gains the additional compatible string and returns -EINVAL when the voltage-low flag is set, matching the rv3032 driver and the behaviour of the Linux driver for the same chips.

Daniel Golle (2):
rtc: pcf8563: add haoyu,hym8563 compatible
rtc: pcf8563: return -EINVAL when the voltage-low flag is set

 drivers/rtc/pcf8563.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

base-commit: ece349ade2973e220f524ce59e59711cc919263f

Signature · 1 line
2.55.0