Skip to content

add anon mTHP collapse test cases

Baolin Wang linux-kselftest linux-mm lkml 3 versions – Applied

Status from this message: [merged mm-stable] selftests-mm-add-mthp-collapse-test-cases.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesApplied 4/4
  2. v24 patches 19 repliesSuperseded
  3. v14 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Collect reviewed/tested tags from Nico, Zi and Kiryl. Thanks.
- Change check_huge_anon/shmem/file()'s parameter type to 'size_t' and rename to 'len' (per Zi).
- Use safe type to calculate the order (per Zi).
- Check return value for read_pmd_pagesize() (per Zi).
- Add more usage() info to indicate that mthp_khugepaged currently only supports anonymous folios (per Zi).
- Other minor coding style changes (per Zi).

Patches in v3 All 4 applied

#Subject and filesSizeRepliesApplied
1/4selftests: mm: extend the check_huge() to support mTHP checktools/testing/selftests/mm/folio_split_race_test.c tools/testing/selftests/mm/khugepaged.c tools/testing/selftests/mm/pagemap_ioctl.c +6 more+56 -480 repliesApplied
2/4selftests: mm: move gather_after_split_folio_orders() into vm_util.c filetools/testing/selftests/mm/split_huge_page_test.c tools/testing/selftests/mm/vm_util.c tools/testing/selftests/mm/vm_util.h+122 -1240 repliesApplied
3/4selftests: mm: implement the mTHP-sized hugepage check helperstools/testing/selftests/mm/vm_util.c+72 -41 replyApplied
4/4selftests: mm: add mTHP collapse test casestools/testing/selftests/mm/khugepaged.c tools/testing/selftests/mm/run_vmtests.sh+120 -191 replyApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchNico Pache (Red Hat)Zi YanKiryl Shutsemau (Meta)
1/4R-b T-b A-b A-b
2/4R-b T-b R-b A-b
3/4R-b T-b R-b A-b
4/4R-b T-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/4] add anon mTHP collapse test cases

This patchset is split from the previous shmem mTHP collapse patchset[1], which only adds anon mTHP collapse selftests. All khugepaged test cases can pass.

[1] https://lore.kernel.org/all/[email protected]/

Changes from v2:
- Collect reviewed/tested tags from Nico, Zi and Kiryl. Thanks.
- Change check_huge_anon/shmem/file()'s parameter type to 'size_t' and rename to 'len' (per Zi).
- Use safe type to calculate the order (per Zi).
- Check return value for read_pmd_pagesize() (per Zi).
- Add more usage() info to indicate that mthp_khugepaged currently only supports anonymous folios (per Zi).
- Other minor coding style changes (per Zi).

Changes from v1:
- Add order and hpage_size check (per Sashiko).
- Change to use THP_MADVISE for mTHP collapse (per Sashiko).

Baolin Wang (4):
selftests: mm: extend the check_huge() to support mTHP check
selftests: mm: move gather_after_split_folio_orders() into vm_util.c
file
selftests: mm: implement the mTHP-sized hugepage check helpers
selftests: mm: add mTHP collapse test cases

 .../selftests/mm/folio_split_race_test.c      |   2 +-
 tools/testing/selftests/mm/khugepaged.c       | 197 +++++++++++++----
 tools/testing/selftests/mm/pagemap_ioctl.c    |   2 +-
 .../testing/selftests/mm/prctl_thp_disable.c  |   2 +-
 tools/testing/selftests/mm/run_vmtests.sh     |   2 +
 tools/testing/selftests/mm/soft-dirty.c       |   2 +-
 .../selftests/mm/split_huge_page_test.c       | 139 +-----------
 tools/testing/selftests/mm/uffd-common.c      |   4 +-
 tools/testing/selftests/mm/vm_util.c          | 201 +++++++++++++++++-
 tools/testing/selftests/mm/vm_util.h          |   8 +-
 10 files changed, 367 insertions(+), 192 deletions(-)
Signature · 1 line
2.47.3