Skip to content

ovpn: fix UDP route cache and endpoint handling

Ralf Lici openvpn-devel 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 1 replyApplied
  2. v25 patches 6 repliesSuperseded
  3. v15 patches 0 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/6ovpn: preserve IPv6 scope id for netlink peer endpointsdrivers/net/ovpn/netlink.c+6 -00 replies
2/6ovpn: skip UDP source validation for unspecified addressesdrivers/net/ovpn/udp.c+4 -30 replies
3/6ovpn: track UDP socket route key for peer dst cachedrivers/net/ovpn/peer.c drivers/net/ovpn/peer.h drivers/net/ovpn/udp.c+95 -150 replies
4/6ovpn: validate peer state before caching UDP dstdrivers/net/ovpn/udp.c+31 -20 replies
5/6ovpn: replace bind when learning local endpointdrivers/net/ovpn/peer.c+23 -200 replies
6/6ovpn: replace bind when clearing stale local sourcedrivers/net/ovpn/udp.c+56 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Openvpn-devel] [PATCH ovpn net v3 0/6] ovpn: fix UDP route cache and endpoint handling

Hi,

This is v3 of a net series that fixes several related issues in ovpn's UDP endpoint and route-cache handling. This version was rebased on top of net and includes suggestions from Sabrina. The former patch 5/5 was dropped from this series and will be sent as RFC on netdev, where it is more appropriate since it involves changes broader than ovpn alone.

This series preserves IPv6 scope IDs supplied through netlink, handles unspecified source addresses correctly, invalidates cached routes when mutable socket route inputs change and avoids in-place updates of RCU-published peer binds.

Support for honoring UDP sockets bound to a device or local address will follow separately for net-next, after these route-cache fixes are available there.

Cheers,

Ralf Lici
Mandelbit Srl

---
Changes since v2 https://lore.kernel.org/openvpn-devel/[email protected]/
- Split former patch 4/5 into three separate patches. (Sabrina)
- Dropped former patch 5/5 from this series as it introduces IPv6
routing changes and needs to be discussed as an RFC on netdev.
(Sabrina)

Changes since v1 https://lore.kernel.org/openvpn-devel/[email protected]
- Patch 5/5: add memory barriers around IPv6 FIB generation reads to
avoid reordering on weakly ordered architectures (Sashiko).

Ralf Lici (6):
ovpn: preserve IPv6 scope id for netlink peer endpoints
ovpn: skip UDP source validation for unspecified addresses
ovpn: track UDP socket route key for peer dst cache
ovpn: validate peer state before caching UDP dst
ovpn: replace bind when learning local endpoint
ovpn: replace bind when clearing stale local source

 drivers/net/ovpn/netlink.c |   6 ++
 drivers/net/ovpn/peer.c    |  44 ++++++-----
 drivers/net/ovpn/peer.h    |  19 ++++-
 drivers/net/ovpn/udp.c     | 193 +++++++++++++++++++++++++++++++++++++--------
 4 files changed, 206 insertions(+), 56 deletions(-)

base-commit: 1b78070aaef63512688aebfbc82365ef9d6660f1

Signature · 8 lines
2.55.0



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel