Skip to content

btrfs: fix generic/795 crash for bs > ps cases

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: initialize inode mapping flags for cached inodesfs/btrfs/inode.c+2 -10 replies
2/2btrfs: add extra ASSERT()s to make sure the folio size is correctfs/btrfs/extent_io.c+19 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFilipe Manana
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs: fix generic/795 crash for bs > ps cases

During my development of the incoming data_size feature, it turns out that we have a new crash triggered by the new test case, generic/795 on bs > ps cases.

It turns out that for cached inode items (btrfs_delayed_node) we can skip the inode mapping flag settings.

This bug is fixed by the first path.

The second patch is to introduce the extra debug ASSERT()s, which greatly reduced the search range by showing the mapping's minimal folio order.

Qu Wenruo (2):
btrfs: initialize inode mapping flags for cached inodes
btrfs: add extra ASSERT()s to make sure the folio size is correct

 fs/btrfs/extent_io.c | 19 +++++++++++++++++++
 fs/btrfs/inode.c     |  3 ++-
 2 files changed, 21 insertions(+), 1 deletion(-)
Signature · 1 line
2.54.0