Skip to content

x86: Trenchboot Secure Launch DRTM (Xen)

Sergii Dmytruk xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest23 patches 9 repliesIn review

Changes in v4 from the cover letter · 16 lines

- added notes to individial commits, the notes below cover some of more generic changes or those spanning multiple commits
- dropped SHA-1 changes (was committed independently of this patchset)
- added CONFIG_SLAUNCH Kconfig option
- TPM driver changes have been moved to the front and are now independent from TPM event log and the rest of this patchset in general
- a few commits were split, joined and/or renamed to make changes more independent, see notes in individual patches
- added support for communicating with TPM2.0 via CRB and memory protection using TPR to support newer handware
- moved UEFI_SLR_TABLE_GUID from xen/include/xen/slr-table.h to xen/common/efi/boot.c
- changed the code for dealing with tables in TXT heap to be iterative
- added more implementation-specific error codes and removed unused ones
- extracted declarations from tpm.c into headers for TPM1.2 and TPM2.0
- return EACCES instead of EPERM when refusing to go into S3 state
- moved SLAUNCH_BOOTLOADER_MAGIC from x86/asm/intel-txt.h to x86/boot/head.S
- moved making MTRR-related functions public to commit which uses them
- use container_of() after slr_next_entry_by_tag() instead of a cast
- made more code that deals with SLRT const-correct (including adding const to the parameter of dl_handler_func)
- absent TPM event log is now consistently allowed by both TPM1.2 and TPM2.0 implementations

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23x86/mtrr: get rid of a static variable on pause/restorexen/arch/x86/cpu/mtrr/generic.c+28 -272 replies
2/23x86/cpu: report SMX, TXT and SKINIT capabilitiesxen/arch/x86/cpu/amd.c xen/arch/x86/cpu/cpu.h xen/arch/x86/cpu/hygon.c +1 more+68 -06 replies
3/23x86/tpm.c: hashing and extending PCRs for TPM1.2xen/arch/x86/Makefile xen/arch/x86/boot/Makefile xen/arch/x86/include/asm/tpm.h +2 more+560 -00 replies
4/23x86/tpm.c: support extending PCRs of TPM2.0 via TISxen/arch/x86/include/asm/tpm.h xen/arch/x86/include/asm/tpm2.h xen/arch/x86/tpm.c+489 -60 replies
5/23x86/tpm.c: add CRB interface supportxen/arch/x86/tpm.c+131 -30 replies
6/23x86/include/asm/intel-txt.h: constants and accessors for TXT registers and heapxen/arch/x86/include/asm/intel-txt.h xen/arch/x86/tboot.c+252 -180 replies
7/23x86/boot: add CONFIG_SLAUNCH, MLE header and Secure Launch entry pointdocs/hypervisor-guide/x86/how-xen-boots.rst xen/arch/x86/Kconfig xen/arch/x86/boot/head.S+94 -00 replies
8/23include/xen/slr-table.h: Secure Launch Resource Table definitionsxen/include/xen/slr-table.h+272 -00 replies
9/23x86/boot/slaunch-early: implement early initializationxen/arch/x86/Makefile xen/arch/x86/boot/Makefile xen/arch/x86/boot/head.S +5 more+183 -30 replies
10/23x86/boot/slaunch-early: early Intel TXT sanity checksxen/arch/x86/boot/slaunch-early.c xen/arch/x86/include/asm/intel-txt.h+124 -00 replies
11/23xen/arch/x86: reserve TXT memory during Slaunchxen/arch/x86/Makefile xen/arch/x86/include/asm/intel-txt.h xen/arch/x86/include/asm/setup.h +6 more+323 -50 replies
12/23x86/slaunch: restore boot MTRRs after Intel TXT DRTMxen/arch/x86/cpu/mtrr/generic.c xen/arch/x86/e820.c xen/arch/x86/include/asm/intel-txt.h +3 more+110 -70 replies
13/23x86/slaunch: measure MBI into TPMxen/arch/x86/boot/Makefile xen/arch/x86/boot/head.S xen/arch/x86/include/asm/slaunch-tpm.h +3 more+148 -10 replies
14/23x86/slaunch: update TPM event log (TPM1.2 or TPM2.0)xen/arch/x86/include/asm/intel-txt.h xen/arch/x86/slaunch-tpm.c+232 -250 replies
15/23x86/hvm: check for VMX in SMX if Slaunch is activexen/arch/x86/hvm/vmx/vmcs.c+2 -10 replies
16/23x86/boot: choose AP stack based on APIC IDxen/arch/x86/boot/head.S xen/arch/x86/boot/trampoline.S xen/arch/x86/boot/x86_64.S +3 more+68 -10 replies
17/23x86/smpboot.c: TXT AP bringupxen/arch/x86/boot/trampoline.S xen/arch/x86/boot/x86_64.S xen/arch/x86/include/asm/intel-txt.h +3 more+125 -20 replies
18/23x86/slaunch: process DRTM policyxen/arch/x86/include/asm/slaunch.h xen/arch/x86/setup.c xen/arch/x86/slaunch.c+246 -00 replies
19/23x86/acpi: disallow S3 on Secure Launch bootxen/arch/x86/acpi/power.c+8 -00 replies
20/23x86/slaunch: support AMD CPUsxen/arch/x86/boot/head.S xen/arch/x86/boot/slaunch-early.c xen/arch/x86/e820.c +4 more+231 -230 replies
21/23x86/slaunch: support EFI boot.gitignore automation/eclair_analysis/ECLAIR/out_of_scope.ecl docs/hypervisor-guide/x86/how-xen-boots.rst +9 more+455 -151 reply
22/23xen/arch/x86: add TPR (TXT Protected Range) DMA protection supportxen/arch/x86/boot/head.S xen/arch/x86/boot/slaunch-early.c xen/arch/x86/efi/efi-boot.h +1 more+151 -480 replies
23/23MAINTAINERS: add a section for TrenchBoot SlaunchMAINTAINERS+19 -00 replies

Reviews trailers per patch

2 of 23 patches have a Reviewed-by or Acked-by.

PatchJan BeulichTeddy Astie
1/23R-b
2/23
3/23
4/23
5/23
6/23
7/23
8/23
9/23
10/23
11/23
12/23
13/23
14/23
15/23A-b
16/23
17/23
18/23
19/23
20/23
21/23
22/23
23/23

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/23] x86: Trenchboot Secure Launch DRTM (Xen)

The aim of the [TrenchBoot] project is to provide an implementation of DRTM that is generic enough to cover various use cases:
- Intel TXT and AMD SKINIT on x86 CPUs
- legacy and UEFI boot
- TPM1.2 and TPM2.0 (TIS and CRB)
- (in the future) DRTM on Arm CPUs

DRTM is a version of a measured launch that starts on request rather than at the start of a boot cycle. One of its advantages is in not including the firmware in the chain of trust.

Xen already supports DRTM via [tboot] which targets Intel TXT only. tboot encapsulates some of the DRTM details within itself while with TrenchBoot Xen (or Linux) is meant to be a self-contained payload for a TrenchBoot-enabled bootloader (think GRUB). The one exception is that UEFI case requires calling back into bootloader to initiate DRTM, which is necessary to give Xen a chance of querying all the information it needs from the firmware before performing DRTM start.

From reading the above tboot might seem like a more abstracted, but the reality is that the payload needs to have DRTM-specific knowledge either way. In principle, TrenchBoot, allows coming up with independent implementations of bootloaders and payloads that are compatible with each other.

The "x86/boot: choose AP stack based on APIC ID" patch is shared with [Parallelize AP bring-up] series and is required here because Intel TXT always releases all APs simultaneously. The rest of the patches are unique.

This version of the patches corresponds to this branch:
https://github.com/TrenchBoot/xen/compare/7c77acd452fb...tb-staging-2026-07-31-v4

-----

[TrenchBoot]: https://trenchboot.org/
[tboot]: https://sourceforge.net/p/tboot/wiki/Home/
[Parallelize AP bring-up]: https://lore.kernel.org/xen-devel/[email protected]/
[v1]: https://lore.kernel.org/xen-devel/[email protected]/
[v2]: https://lore.kernel.org/xen-devel/[email protected]/
[v3]: https://lore.kernel.org/xen-devel/[email protected]/

-----

Changes in v4:
- added notes to individial commits, the notes below cover some of more generic changes or those spanning multiple commits
- dropped SHA-1 changes (was committed independently of this patchset)
- added CONFIG_SLAUNCH Kconfig option
- TPM driver changes have been moved to the front and are now independent from TPM event log and the rest of this patchset in general
- a few commits were split, joined and/or renamed to make changes more independent, see notes in individual patches
- added support for communicating with TPM2.0 via CRB and memory protection using TPR to support newer handware
- moved UEFI_SLR_TABLE_GUID from xen/include/xen/slr-table.h to xen/common/efi/boot.c
- changed the code for dealing with tables in TXT heap to be iterative
- added more implementation-specific error codes and removed unused ones
- extracted declarations from tpm.c into headers for TPM1.2 and TPM2.0
- return EACCES instead of EPERM when refusing to go into S3 state
- moved SLAUNCH_BOOTLOADER_MAGIC from x86/asm/intel-txt.h to x86/boot/head.S
- moved making MTRR-related functions public to commit which uses them
- use container_of() after slr_next_entry_by_tag() instead of a cast
- made more code that deals with SLRT const-correct (including adding const to the parameter of dl_handler_func)
- absent TPM event log is now consistently allowed by both TPM1.2 and TPM2.0 implementations

Changes in [v3]:
- sorted F: entries in MAINTAINERS file
- made sha1 implementation more similar to sha256
- dropped unused parameter from xen/arch/x86/cpu/intel.c:intel_log_smx_txt()
- updated header guards according to new style
- xen/arch/x86/include/asm/intel-txt.h:
+ briefly explained what TXT is
+ renamed: NR_TXT_CONFIG_SIZE -> TXT_CONFIG_SPACE_SIZE
+ renamed: read_txt_reg() -> txt_read()
+ renamed: write_txt_reg() -> txt_write()
+ marked txt_reset() as noreturn and used unreacheable() instead of

     while(1)

+ explained a bit more about TXT Heap
- xen/include/xen/slr-table.h:
+ briefly explained what SLRT is
+ fixed checks in slr_next_entry()
- SPDX-License-Identifier: GPL-2.0 -> GPL-2.0-only
- made more code const-correct
- use arithmetic on pointers to void instead of pointers to uint8_t

Changes in [v2]:
- using dashes instead of underscores in the names of new files
- dropping of an extra sha256 implementation
- rewriting sha1 implementation to be in line with already present sha256 implementation (simplifying it and getting rid of macros)
- correct placement of new lines in Makefile
- add header guards to all new files
- use correct names for header guards in new files
- update license of xen/include/xen/slr-table.h
- changed fixmlehdr to search for header within 8 instead of 4 KiB file prefix
- don't print DRTM-related capabilities when resuming from S3
- forbade S3 in case of Secure Launch
- fixed an issue with resuming from S3 caused by inappropriate use of __initdata
- added a new section to MAINTAINERS
- improved commit messages
- fixed MISRA C violations:
+ shadowing of e820 global
+ missing U literal suffixes
+ use of ull literal suffix
+ excluded fixmlehdr from analysis (similar to other build tools)
+ use of 0 instead of NULL in one place
+ provided declarations for some definitions
+ marked asm-invoked functions with asmlinkage

-----

Kacper Stojek (2):
x86/boot: add CONFIG_SLAUNCH, MLE header and Secure Launch entry point xen/arch/x86: reserve TXT memory during Slaunch

Krystian Hebel (7):
x86/tpm.c: hashing and extending PCRs for TPM1.2 x86/include/asm/intel-txt.h: constants and accessors for TXT registers
and heap
x86/boot/slaunch-early: early Intel TXT sanity checks x86/slaunch: restore boot MTRRs after Intel TXT DRTM x86/slaunch: measure MBI into TPM
x86/boot: choose AP stack based on APIC ID
x86/smpboot.c: TXT AP bringup

Michał Żygowski (2):
x86/cpu: report SMX, TXT and SKINIT capabilities x86/hvm: check for VMX in SMX if Slaunch is active

Sergii Dmytruk (10):
x86/mtrr: get rid of a static variable on pause/restore x86/tpm.c: support extending PCRs of TPM2.0 via TIS include/xen/slr-table.h: Secure Launch Resource Table definitions x86/boot/slaunch-early: implement early initialization x86/slaunch: update TPM event log (TPM1.2 or TPM2.0) x86/slaunch: process DRTM policy
x86/acpi: disallow S3 on Secure Launch boot x86/slaunch: support AMD CPUs
x86/slaunch: support EFI boot
MAINTAINERS: add a section for TrenchBoot Slaunch

Szymon Acedański (2):
x86/tpm.c: add CRB interface support
xen/arch/x86: add TPR (TXT Protected Range) DMA protection support

 .gitignore                                    |   1 +
 MAINTAINERS                                   |  19 +
 .../eclair_analysis/ECLAIR/out_of_scope.ecl   |   1 +
 docs/hypervisor-guide/x86/how-xen-boots.rst   |  12 +
 xen/arch/x86/Kconfig                          |   8 +
 xen/arch/x86/Makefile                         |  16 +-
 xen/arch/x86/acpi/power.c                     |   8 +
 xen/arch/x86/boot/Makefile                    |  22 +-
 xen/arch/x86/boot/head.S                      | 267 ++++++
 xen/arch/x86/boot/slaunch-early.c             | 104 +++
 xen/arch/x86/boot/trampoline.S                |  42 +-
 xen/arch/x86/boot/x86_64.S                    |  67 +-
 xen/arch/x86/cpu/amd.c                        |  16 +
 xen/arch/x86/cpu/cpu.h                        |   1 +
 xen/arch/x86/cpu/hygon.c                      |   1 +
 xen/arch/x86/cpu/intel.c                      |  50 +
 xen/arch/x86/cpu/mtrr/generic.c               |  50 +-
 xen/arch/x86/e820.c                           |   5 +
 xen/arch/x86/efi/efi-boot.h                   |  95 +-
 xen/arch/x86/efi/fixmlehdr.c                  | 127 +++
 xen/arch/x86/hvm/vmx/vmcs.c                   |   3 +-
 xen/arch/x86/include/asm/apicdef.h            |   4 +
 xen/arch/x86/include/asm/intel-txt.h          | 573 ++++++++++++
 xen/arch/x86/include/asm/msr-index.h          |   3 +
 xen/arch/x86/include/asm/mtrr.h               |   8 +
 xen/arch/x86/include/asm/processor.h          |   1 +
 xen/arch/x86/include/asm/setup.h              |   3 +
 xen/arch/x86/include/asm/slaunch-tpm.h        |  26 +
 xen/arch/x86/include/asm/slaunch.h            | 128 +++
 xen/arch/x86/include/asm/tpm.h                |  74 ++
 xen/arch/x86/include/asm/tpm1.h               |  94 ++
 xen/arch/x86/include/asm/tpm2.h               | 150 +++
 xen/arch/x86/intel-txt.c                      | 197 ++++
 xen/arch/x86/setup.c                          |  32 +-
 xen/arch/x86/slaunch-tpm.c                    | 312 +++++++
 xen/arch/x86/slaunch.c                        | 478 ++++++++++
 xen/arch/x86/smpboot.c                        |  75 ++
 xen/arch/x86/tboot.c                          |  20 +-
 xen/arch/x86/tpm.c                            | 862 ++++++++++++++++++
 xen/arch/x86/x86_64/asm-offsets.c             |  13 +
 xen/common/efi/boot.c                         |   6 +
 xen/common/efi/runtime.c                      |   1 +
 xen/include/xen/efi.h                         |   1 +
 xen/include/xen/slr-table.h                   | 272 ++++++
 44 files changed, 4191 insertions(+), 57 deletions(-)
 create mode 100644 xen/arch/x86/boot/slaunch-early.c
 create mode 100644 xen/arch/x86/efi/fixmlehdr.c
 create mode 100644 xen/arch/x86/include/asm/intel-txt.h
 create mode 100644 xen/arch/x86/include/asm/slaunch-tpm.h
 create mode 100644 xen/arch/x86/include/asm/slaunch.h
 create mode 100644 xen/arch/x86/include/asm/tpm.h
 create mode 100644 xen/arch/x86/include/asm/tpm1.h
 create mode 100644 xen/arch/x86/include/asm/tpm2.h
 create mode 100644 xen/arch/x86/intel-txt.c
 create mode 100644 xen/arch/x86/slaunch-tpm.c
 create mode 100644 xen/arch/x86/slaunch.c
 create mode 100644 xen/arch/x86/tpm.c
 create mode 100644 xen/include/xen/slr-table.h

base-commit: 7c77acd452fb6a3079661e75ebb5cf23ed985cc7

Signature · 1 line
2.55.0